summaryrefslogtreecommitdiff
path: root/os2
diff options
context:
space:
mode:
authorIlya Zakharevich <ilya@math.berkeley.edu>1998-02-25 21:47:46 -0500
committerMalcolm Beattie <mbeattie@sable.ox.ac.uk>1998-02-27 15:26:45 +0000
commitc2267164204a961273c71c9c103831895724b0b1 (patch)
treee1be7d708a8588e9df821cc20be5a32e5ac3493a /os2
parent4e2a5f63925503b57176e32249cf6e160bcf9be9 (diff)
downloadperl-c2267164204a961273c71c9c103831895724b0b1.tar.gz
Fix file-descriptor leak when pipes fail via taint checks:
Subject: [PATCH] Some patches went through cracks p4raw-id: //depot/perl@593
Diffstat (limited to 'os2')
-rw-r--r--os2/os2.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/os2/os2.c b/os2/os2.c
index fe7f99bb7e..f24c3af5ce 100644
--- a/os2/os2.c
+++ b/os2/os2.c
@@ -620,8 +620,6 @@ char *mode;
PerlIO *res;
SV *sv;
- if (pipe(p) < 0)
- return Nullfp;
/* `this' is what we use in the parent, `that' in the child. */
this = (*mode == 'w');
that = !this;
@@ -629,6 +627,8 @@ char *mode;
taint_env();
taint_proper("Insecure %s%s", "EXEC");
}
+ if (pipe(p) < 0)
+ return Nullfp;
/* Now we need to spawn the child. */
newfd = dup(*mode == 'r'); /* Preserve std* */
if (p[that] != (*mode == 'r')) {