Use the same outside logic for mysubs and formats

By using find_runcv_where both for formats and my subs nested in inner
clonable subs, we can simplify the code.

It happens to make this work ($x is visible):

use 5.01;
sub not_lexical8 {
  my sub foo;
  foo();
  sub not_lexical9 {
    my sub bar {
      my $x = 'khaki car keys for the khaki car';
      not_lexical8();
      sub foo { warn $x }
    }
    bar()
  }
}
not_lexical9();

This is definitely iffy code, but if making it work makes the imple-
mentation simpler, so why not?

1 files changed, 1 insertions, 11 deletions

diff --git a/pad.c b/pad.c
index 03cb555379..85aeea51fe 100644
--- a/pad.c
+++ b/pad.c
@@ -1985,18 +1985,8 @@ S_cv_clone_pad(pTHX_ CV *proto, CV *cv, CV *outside)
      */
 
     if (!outside) {
-      if (SvTYPE(proto) == SVt_PVCV)
-      {
+      if (CvWEAKOUTSIDE(proto))
 	outside = find_runcv(NULL);
-	if (!CvANON(proto)) {
-	    if (!CvPADLIST(outside) ||
-	        CvPADLIST(outside)->xpadl_id != protopadlist->xpadl_outid)
-		outside = CvOUTSIDE(proto);
-	    if (!CvPADLIST(outside) ||
-	        CvPADLIST(outside)->xpadl_id != protopadlist->xpadl_outid)
-		outside = NULL;
-	}
-      }
       else {
 	outside = CvOUTSIDE(proto);
 	if ((CvCLONE(outside) && ! CvCLONED(outside))