diff options
| author | Zefram <zefram@fysh.org> | 2017-12-06 04:00:04 +0000 |
|---|---|---|
| committer | Zefram <zefram@fysh.org> | 2017-12-06 04:00:04 +0000 |
| commit | 52e3acf87aacbe6b39ecb42fe0adb6c0dac1019d (patch) | |
| tree | d789ce56ac7364b4acb33c4c492a715efc55eb0c /pad.c | |
| parent | 58be57636a42d6c6fd404c48c4e1cb87870182df (diff) | |
| download | perl-52e3acf87aacbe6b39ecb42fe0adb6c0dac1019d.tar.gz | |
put shadowing warnings in their own category
As proposed in [perl #125330].
Diffstat (limited to 'pad.c')
| -rw-r--r-- | pad.c | 8 |
1 files changed, 4 insertions, 4 deletions
@@ -857,7 +857,7 @@ S_pad_check_dup(pTHX_ PADNAME *name, U32 flags, const HV *ourstash) assert((flags & ~padadd_OUR) == 0); - if (PadnamelistMAX(PL_comppad_name) < 0 || !ckWARN(WARN_MISC)) + if (PadnamelistMAX(PL_comppad_name) < 0 || !ckWARN(WARN_SHADOW)) return; /* nothing to check */ svp = PadnamelistARRAY(PL_comppad_name); @@ -875,7 +875,7 @@ S_pad_check_dup(pTHX_ PADNAME *name, U32 flags, const HV *ourstash) if (is_our && (SvPAD_OUR(sv))) break; /* "our" masking "our" */ /* diag_listed_as: "%s" variable %s masks earlier declaration in same %s */ - Perl_warner(aTHX_ packWARN(WARN_MISC), + Perl_warner(aTHX_ packWARN(WARN_SHADOW), "\"%s\" %s %" PNf " masks earlier declaration in same %s", ( is_our ? "our" : PL_parser->in_my == KEY_my ? "my" : @@ -901,10 +901,10 @@ S_pad_check_dup(pTHX_ PADNAME *name, U32 flags, const HV *ourstash) && SvOURSTASH(sv) == ourstash && memEQ(PadnamePV(sv), PadnamePV(name), PadnameLEN(name))) { - Perl_warner(aTHX_ packWARN(WARN_MISC), + Perl_warner(aTHX_ packWARN(WARN_SHADOW), "\"our\" variable %" PNf " redeclared", PNfARG(sv)); if (off <= PL_comppad_name_floor) - Perl_warner(aTHX_ packWARN(WARN_MISC), + Perl_warner(aTHX_ packWARN(WARN_SHADOW), "\t(Did you mean \"local\" instead of \"our\"?)\n"); break; } |