diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2013-07-05 22:51:50 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2013-08-09 19:44:13 -0700 |
| commit | 1dc74fdba201402174cfbd293adc42f5a0bafc22 (patch) | |
| tree | bf675ece5baae52ad8e311dd1b9de36514736c4c /perl.c | |
| parent | 449dd03960bf018889fc68eb9ff03ef613eb893b (diff) | |
| download | perl-1dc74fdba201402174cfbd293adc42f5a0bafc22.tar.gz | |
Revert "[perl #117855] Store CopFILEGV in a pad under ithreads"
This reverts commit c82ecf346.
It turn out to be faulty, because a location shared betweens threads
(the cop) was holding a reference count on a pad entry in a particu-
lar thread. So when you free the cop, how do you know where to do
SvREFCNT_dec?
In reverting c82ecf346, this commit still preserves the bug fix from
1311cfc0a7b, but shifts it around.
Diffstat (limited to 'perl.c')
| -rw-r--r-- | perl.c | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -286,7 +286,6 @@ perl_construct(pTHXx) Perl_av_create_and_push(aTHX_ &PL_regex_padav, newSVpvs("")); PL_regex_pad = AvARRAY(PL_regex_padav); Newxz(PL_stashpad, PL_stashpadmax, HV *); - Newxz(PL_filegvpad, PL_filegvpadmax, GV *); #endif #ifdef USE_REENTRANT_API Perl_reentrant_init(aTHX); @@ -1093,7 +1092,6 @@ perl_destruct(pTHXx) #ifdef USE_ITHREADS Safefree(PL_stashpad); /* must come after sv_clean_all */ - Safefree(PL_filegvpad); #endif AvREAL_off(PL_fdpid); /* no surviving entries */ |