RT #76248: double-freed SV with nested sig-handler

There was some buggy code in Perl_sighandler() related to getting an SV
with the signal name to pass to the perl-level handler function.
`
Basically:

on threaded builds, a sig handler that died leaked PL_psig_name[sig];
on unthreaded builds, in a recursive handler that died, PL_sig_sv was
prematurely freed.

PL_sig_sv was originally just a file static var that was not
recursion-save anyway, and got promoted to perlvars.h when it should
instead have been done away with. So I've got rid of it now, and
rationalised the code, which fixed the two issues listed above.

Also added an assert which makes the dodgy manual popping of the save
stack slightly less dodgy.

1 files changed, 0 insertions, 2 deletions

diff --git a/perlapi.h b/perlapi.h
index 151eacc2c9..1c64ec72c3 100644
--- a/perlapi.h
+++ b/perlapi.h
@@ -177,8 +177,6 @@ END_EXTERN_C
 #define PL_sig_handlers_initted	(*Perl_Gsig_handlers_initted_ptr(NULL))
 #undef  PL_sig_ignoring
 #define PL_sig_ignoring		(*Perl_Gsig_ignoring_ptr(NULL))
-#undef  PL_sig_sv
-#define PL_sig_sv		(*Perl_Gsig_sv_ptr(NULL))
 #undef  PL_sig_trapped
 #define PL_sig_trapped		(*Perl_Gsig_trapped_ptr(NULL))
 #undef  PL_sigfpe_saved