diff options
| author | David Mitchell <davem@iabyn.com> | 2010-11-01 15:36:44 +0000 |
|---|---|---|
| committer | David Mitchell <davem@iabyn.com> | 2010-11-01 16:38:31 +0000 |
| commit | 0c4d3b5ea916cf640ea163c5a6bcffefade55a1b (patch) | |
| tree | be11e83d70151641a17c462acac3c4e7a4f04a10 /perlvars.h | |
| parent | 51698cb360d5bba06e12496ef9c7bf82e3352b71 (diff) | |
| download | perl-0c4d3b5ea916cf640ea163c5a6bcffefade55a1b.tar.gz | |
RT #76248: double-freed SV with nested sig-handler
There was some buggy code in Perl_sighandler() related to getting an SV
with the signal name to pass to the perl-level handler function.
`
Basically:
on threaded builds, a sig handler that died leaked PL_psig_name[sig];
on unthreaded builds, in a recursive handler that died, PL_sig_sv was
prematurely freed.
PL_sig_sv was originally just a file static var that was not
recursion-save anyway, and got promoted to perlvars.h when it should
instead have been done away with. So I've got rid of it now, and
rationalised the code, which fixed the two issues listed above.
Also added an assert which makes the dodgy manual popping of the save
stack slightly less dodgy.
Diffstat (limited to 'perlvars.h')
| -rw-r--r-- | perlvars.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/perlvars.h b/perlvars.h index e424913d95..1a44e22e4e 100644 --- a/perlvars.h +++ b/perlvars.h @@ -102,10 +102,6 @@ PERLVARA(Gsig_ignoring, SIG_SIZE, int) /* which signals we are ignoring */ PERLVARA(Gsig_defaulting, SIG_SIZE, int) #endif -#ifndef PERL_IMPLICIT_CONTEXT -PERLVAR(Gsig_sv, SV*) -#endif - /* XXX signals are process-wide anyway, so we * ignore the implications of this for threading */ #ifndef HAS_SIGACTION |