diff options
author | Karl Williamson <khw@cpan.org> | 2020-05-18 14:40:04 -0600 |
---|---|---|
committer | Sawyer X <xsawyerx@cpan.org> | 2020-06-02 12:17:47 +0300 |
commit | 668d19980931e86058b46a58d0328c3b881b8aa1 (patch) | |
tree | 24af2a04d7083dfb544b75a6920ce1cc48fa36f0 /perlvars.h | |
parent | cac6698e074af8daec0f7011cd77824d5d849d6f (diff) | |
download | perl-668d19980931e86058b46a58d0328c3b881b8aa1.tar.gz |
Make PL_utf8_foldclosures interpreter level
This resolves #17774.
This ticket is because the fixes in GH #17154 failed to get every case,
leaving this one outlier to be fixed by this commit.
The text in https://github.com/Perl/perl5/issues/17154 gives extensive
details as to the problem. But briefly, in an attempt to speed up
interpreter cloning, I moved certain SVs from interpreter level to
global level in e80a0113c4a8036dfb22aec44d0a9feb65d36fed (v5.27.11,
March 2018). This was doable, we thought, because the content of these
SVs is constant throughout the life of the program, so no need to copy
them when cloning a new interpreter or thread. However when an
interpreter exits, all its SVs get cleaned up, which caused these to
become garbage in applications where another interpreter remains
running. This circumstance is rare enough that the bug wasn't reported
until September 2019, #17154. I made an initial attempt to fix the
problem, and closed that ticket, but I overlooked one of the variables,
which was reported in #17774, which this commit addresses.
Effectively the behavior is reverted to the way it was before
e80a0113c4a8036dfb22aec44d0a9feb65d36fed.
Diffstat (limited to 'perlvars.h')
-rw-r--r-- | perlvars.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/perlvars.h b/perlvars.h index 0892332a63..cd1523d5df 100644 --- a/perlvars.h +++ b/perlvars.h @@ -305,10 +305,6 @@ PERLVAR(G, user_prop_mutex, perl_mutex) /* Mutex for manipulating PL_user_defined_properties */ #endif -/* Everything that folds to a given character, for case insensitivity regex - * matching */ -PERLVAR(G, utf8_foldclosures, SV *) - /* these record the best way to perform certain IO operations while * atomically setting FD_CLOEXEC. On the first call, a probe is done * and the result recorded for use by subsequent calls. |