diff options
| author | Nicholas Clark <nick@ccl4.org> | 2001-11-23 18:12:21 +0000 |
|---|---|---|
| committer | Jarkko Hietaniemi <jhi@iki.fi> | 2001-11-23 17:11:58 +0000 |
| commit | a936dd3cbec3db0be0468f4b4ca8007aa78279f6 (patch) | |
| tree | 42ac5adbff231cb898f9c8cdfebcbd2769d87d76 /pod/perlhack.pod | |
| parent | a5b3542311a661393000cf5958d4b96624f4ef77 (diff) | |
| download | perl-a936dd3cbec3db0be0468f4b4ca8007aa78279f6.tar.gz | |
Tests are good
Message-ID: <20011123181220.F37621@plum.flirble.org>
p4raw-id: //depot/perl@13208
Diffstat (limited to 'pod/perlhack.pod')
| -rw-r--r-- | pod/perlhack.pod | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/pod/perlhack.pod b/pod/perlhack.pod index 49d7625ab0..371b6b5f72 100644 --- a/pod/perlhack.pod +++ b/pod/perlhack.pod @@ -157,13 +157,22 @@ The worst patches make use of a system-specific features. It's highly unlikely that nonportable additions to the Perl language will be accepted. +=item Is the implementation tested? + +Patches which change behaviour (fixing bugs or introducing new features) +must include regression tests to verify that everything works as expected. +Without tests provided by the original author, how can anyone else changing +perl in the future be sure that they haven't unwittingly broken the behaviour +the patch implements? And without tests, how can the patch's author be +confident that his/her hard work put into the patch won't be accidently +thrown away by someone in the future? + =item Is there enough documentation? Patches without documentation are probably ill-thought out or incomplete. Nothing can be added without documentation, so submitting a patch for the appropriate manpages as well as the source code is -always a good idea. If appropriate, patches should add to the test -suite as well. +always a good idea. =item Is there another way to do it? |