Add a new macro SvPV_free() which undoes OOK and free()s the PVX(),

becase there's a lot of code around that calls SvOOK_off(), memmov()s
the buffer, then promptly free()s it. So avoid the needless memmov().

p4raw-id: //depot/perl@24348

1 files changed, 2 insertions, 5 deletions

diff --git a/pp.c b/pp.c
index ca4f61d4cb..4500c575de 100644
--- a/pp.c
+++ b/pp.c
@@ -175,9 +175,7 @@ PP(pp_rv2gv)
 		    if (SvTYPE(sv) < SVt_RV)
 			sv_upgrade(sv, SVt_RV);
 		    if (SvPVX(sv)) {
-			SvOOK_off(sv);		/* backoff */
-			if (SvLEN(sv))
-			    Safefree(SvPVX(sv));
+			SvPV_free(sv);
 			SvLEN_set(sv, 0);
                         SvCUR_set(sv, 0);
 		    }
@@ -825,8 +823,7 @@ PP(pp_undef)
 	break;
     default:
 	if (SvTYPE(sv) >= SVt_PV && SvPVX(sv) && SvLEN(sv)) {
-	    SvOOK_off(sv);
-	    Safefree(SvPVX(sv));
+	    SvPV_free(sv);
 	    SvPV_set(sv, Nullch);
 	    SvLEN_set(sv, 0);
 	}