diff options
| author | Dave Mitchell <davem@fdisolutions.com> | 2005-07-13 00:21:13 +0000 |
|---|---|---|
| committer | Dave Mitchell <davem@fdisolutions.com> | 2005-07-13 00:21:13 +0000 |
| commit | 041457d90dbb6fb79a72c7a8462f01423f2daa09 (patch) | |
| tree | 5393e1e2a48eb57f050aa85b76a30b7f9f198257 /pp.c | |
| parent | e352bcff231c07cf21f07ae801f374a3da3229ed (diff) | |
| download | perl-041457d90dbb6fb79a72c7a8462f01423f2daa09.tar.gz | |
make the expensive ckWARN() be called as late as possible
reorganise
if (ckWARN(FOO) && should_not_happen_condition)
to
if (should_not_happen_condition && ckWARN(FOO))
p4raw-id: //depot/perl@25129
Diffstat (limited to 'pp.c')
| -rw-r--r-- | pp.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -531,7 +531,7 @@ PP(pp_bless) if (ssv && !SvGMAGICAL(ssv) && !SvAMAGIC(ssv) && SvROK(ssv)) Perl_croak(aTHX_ "Attempt to bless into a reference"); ptr = SvPV_const(ssv,len); - if (ckWARN(WARN_MISC) && len == 0) + if (len == 0 && ckWARN(WARN_MISC)) Perl_warner(aTHX_ packWARN(WARN_MISC), "Explicit blessing to '' (assuming package main)"); stash = gv_stashpvn(ptr, len, TRUE); @@ -789,7 +789,7 @@ PP(pp_undef) hv_undef((HV*)sv); break; case SVt_PVCV: - if (ckWARN(WARN_MISC) && cv_const_sv((CV*)sv)) + if (cv_const_sv((CV*)sv) && ckWARN(WARN_MISC)) Perl_warner(aTHX_ packWARN(WARN_MISC), "Constant subroutine %s undefined", CvANON((CV*)sv) ? "(anonymous)" : GvENAME(CvGV((CV*)sv))); /* FALL THROUGH */ |