summaryrefslogtreecommitdiff
path: root/pp_ctl.c
diff options
context:
space:
mode:
authorFather Chrysostomos <sprout@cpan.org>2011-06-17 09:33:26 -0700
committerFather Chrysostomos <sprout@cpan.org>2011-06-17 13:32:58 -0700
commit65613fc23b9817bb12168505453c08d1b6b1baf2 (patch)
treeda12c4fcdf205c9b6f7d7938c65645110e0af64b /pp_ctl.c
parentbc5a39a8e07f10d4372b4fc74847688f6c28d754 (diff)
downloadperl-65613fc23b9817bb12168505453c08d1b6b1baf2.tar.gz
Remove unnecessary code and tests
This test was relying on bug #91844. As that has been fixed (by com- mit 3ed94dc, which erroneously claimed to fix #81944), this test is not testing what it purports to test. Also as a result of that bug fix, it doesn’t matter if the TEMP flag is set, I can get rid of the SvTEMP_off. The only effects the TEMP flag can have now occur only when the refcount is 1, but since *_ holds a refcount and the mortals stack does as well, it’s going to be 2 unless someone undefs *_, in which case the callback won’t have any reference to it. If it tries to make a weak reference, doing so will turn TEMP off.
Diffstat (limited to 'pp_ctl.c')
-rw-r--r--pp_ctl.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/pp_ctl.c b/pp_ctl.c
index 303e3565d6..04dd31b646 100644
--- a/pp_ctl.c
+++ b/pp_ctl.c
@@ -5295,7 +5295,6 @@ S_run_user_filter(pTHX_ int idx, SV *buf_sv, int maxlen)
I'm going to use a mortal in case the upstream filter croaks. */
upstream = ((SvOK(buf_sv) && sv_len(buf_sv)) || SvGMAGICAL(buf_sv))
? sv_newmortal() : buf_sv;
- SvTEMP_off(upstream);
SvUPGRADE(upstream, SVt_PV);
if (filter_has_file) {