diff options
author | Father Chrysostomos <sprout@cpan.org> | 2013-08-09 18:14:31 -0700 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2013-08-11 07:50:22 -0700 |
commit | dc423e963cc02ea1e95f95395eeecffac6e489eb (patch) | |
tree | 16208e3620fdb0cfc9e90203ec8b569f8e026756 /pp_ctl.c | |
parent | 2e8409ad08dc8f8f81c8bdba02f7423a301ff4e0 (diff) | |
download | perl-dc423e963cc02ea1e95f95395eeecffac6e489eb.tar.gz |
pp_ctl.c:S_run_user_filter: remove GMAGICAL check
We have already called get-magic at this point, so SvOK will give
the right answer even for magical variables. Concatenating it when
gmagical could give an uninitialised warning if it is undef, so
we don’t want to do that, as it would cause magical and non-mag-
ical undefs to behave differently. I don’t know how to write a
test for this.
Diffstat (limited to 'pp_ctl.c')
-rw-r--r-- | pp_ctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -5513,7 +5513,7 @@ S_run_user_filter(pTHX_ int idx, SV *buf_sv, int maxlen) concatenate it then we get a warning about use of uninitialised value. */ if (!err && upstream != buf_sv && - (SvOK(upstream) || SvGMAGICAL(upstream))) { + SvOK(upstream)) { sv_catsv_nomg(buf_sv, upstream); } else if (SvOK(upstream)) (void)SvPV_force_nolen(buf_sv); |