create Perl_hv_pushkv() function

...and make pp_padhv(), pp_rv2hv() use it rather than using Perl_do_kv()

Both pp_padhv() and pp_rv2hv() (via S_padhv_rv2hv_common()), outsource to
Perl_do_kv(), the list-context pushing/flattening of a hash onto the
stack.

Perl_do_kv() is a big function that handles all the actions of
keys, values etc. Instead, create a new function which does just the
pushing of a hash onto the stack.

At the same time, split it out into two loops, one for tied, one for
normal: the untied one can skip extending the stack on each iteration,
and use a cheaper HeVAL() instead of calling hv_iterval().

1 files changed, 3 insertions, 4 deletions

diff --git a/pp_hot.c b/pp_hot.c
index 67729690b9..079fe35bce 100644
--- a/pp_hot.c
+++ b/pp_hot.c
@@ -968,7 +968,7 @@ PP(pp_print)
 
 /* do the common parts of pp_padhv() and pp_rv2hv()
  * It assumes the caller has done EXTEND(SP, 1) or equivalent.
- * 'is_keys' indicates the OPpPADHV_ISKEYS/OPpRV2HV_ISKEYS flag is set
+ * 'is_keys' indicates the OPpPADHV_ISKEYS/OPpRV2HV_ISKEYS flag is set.
  * 'has_targ' indicates that the op has a target - this should
  * be a compile-time constant so that the code can constant-folded as
  * appropriate
@@ -983,9 +983,8 @@ S_padhv_rv2hv_common(pTHX_ HV *hv, U8 gimme, bool is_keys, bool has_targ)
     assert(PL_op->op_type == OP_PADHV || PL_op->op_type == OP_RV2HV);
 
     if (gimme == G_ARRAY) {
-        PUSHs(MUTABLE_SV(hv));
-        PUTBACK;
-        return Perl_do_kv(aTHX);
+        hv_pushkv(hv);
+        return NORMAL;
     }
 
     if (is_keys)