diff options
| author | Karl Williamson <public@khwilliamson.com> | 2014-02-19 21:14:44 -0700 |
|---|---|---|
| committer | Karl Williamson <public@khwilliamson.com> | 2014-02-19 21:29:23 -0700 |
| commit | ed885487570a4a0046b0cb32a477526f8f016d93 (patch) | |
| tree | 777e8a482999226c4889e36177047b4bffc62be2 /proto.h | |
| parent | d3db5cfeb8346f308b4354ee1c8970ab9b526472 (diff) | |
| download | perl-ed885487570a4a0046b0cb32a477526f8f016d93.tar.gz | |
regcomp.c: Don't read uninitialized data
I keep forgetting that the OP of a regnode is not defined in Pass 1 of
the regex compiler. This is likely the cause of inconsistent results in
lib/locale.t, as valgrind shows there to be a read of uninitialized
data before this patch, and the result is randomly tainting when there
shouldn't be, consistent with the test failures.
Diffstat (limited to 'proto.h')
| -rw-r--r-- | proto.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -6607,7 +6607,7 @@ STATIC U32 S_add_data(RExC_state_t* const pRExC_state, const char* const s, cons #define PERL_ARGS_ASSERT_ADD_DATA \ assert(pRExC_state); assert(s) -PERL_STATIC_INLINE void S_alloc_maybe_populate_EXACT(pTHX_ RExC_state_t *pRExC_state, regnode *node, I32 *flagp, STRLEN len, UV code_point, const bool downgradable) +PERL_STATIC_INLINE void S_alloc_maybe_populate_EXACT(pTHX_ RExC_state_t *pRExC_state, regnode *node, I32 *flagp, STRLEN len, UV code_point, bool downgradable) __attribute__nonnull__(pTHX_1) __attribute__nonnull__(pTHX_2) __attribute__nonnull__(pTHX_3); |