[perl #31851] Threading crash with closures

various OpREFCNT_inc() operations weren't doing locking

p4raw-id: //depot/perl@23433

1 files changed, 5 insertions, 0 deletions

diff --git a/regcomp.c b/regcomp.c
index 7587498efb..2bcb16e0a9 100644
--- a/regcomp.c
+++ b/regcomp.c
@@ -4983,9 +4983,14 @@ Perl_pregfree(pTHX_ struct regexp *r)
 		    (SvTYPE(new_comppad) == SVt_PVAV) ?
 		    		new_comppad : Null(PAD *)
 		);
+		OP_REFCNT_LOCK;
 		if (!OpREFCNT_dec((OP_4tree*)r->data->data[n])) {
+		    OP_REFCNT_UNLOCK;
                     op_free((OP_4tree*)r->data->data[n]);
 		}
+		else {
+		    OP_REFCNT_UNLOCK;
+		}
 
 		PAD_RESTORE_LOCAL(old_comppad);
 		SvREFCNT_dec((SV*)new_comppad);