diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2013-05-26 19:12:50 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2013-05-26 19:13:43 -0700 |
| commit | 675fa9ffbd41c6a7cf9b032d83e33f112a700be1 (patch) | |
| tree | 5d6184d64e924d2aa8b441056b3ad69931b821c4 /regcomp.c | |
| parent | 22bb4385a9b065ce689d7e657983730ed51ea69f (diff) | |
| download | perl-675fa9ffbd41c6a7cf9b032d83e33f112a700be1.tar.gz | |
perldiag: miscellaneous clean-up
•‘Corrupted regexp opcode’ is a ‘can’t happen’ error, so it belongs
in the P category.
• Two spaces after dots for consistency
• Rewrap for slightly better splain output
• The description usually begins on the same line as the category, so
do so consistently
• Reorder alphabetically
• Missing category
• Single, not double, backslash
• Squash two adjacent (due to reordering) entries with identical
descriptions
• ‘given’ does not depend on lexical $_ any more
• Remove duplicate entries (and placate diag.t with diag_listed_as)
Diffstat (limited to 'regcomp.c')
| -rw-r--r-- | regcomp.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -8542,6 +8542,7 @@ S_parse_lparen_question_flags(pTHX_ struct RExC_state_t *pRExC_state) const I32 wflagbit = *RExC_parse == 'o' ? WASTED_O : WASTED_G; if (! (wastedflags & wflagbit) ) { wastedflags |= wflagbit; + /* diag_listed_as: Useless (?-%s) - don't use /%s modifier in regex; marked by <-- HERE in m/%s/ */ vWARN5( RExC_parse + 1, "Useless (%s%c) - %suse /%c modifier", @@ -8558,6 +8559,7 @@ S_parse_lparen_question_flags(pTHX_ struct RExC_state_t *pRExC_state) if (SIZE_ONLY && ckWARN(WARN_REGEXP)) { if (! (wastedflags & WASTED_C) ) { wastedflags |= WASTED_GC; + /* diag_listed_as: Useless (?-%s) - don't use /%s modifier in regex; marked by <-- HERE in m/%s/ */ vWARN3( RExC_parse + 1, "Useless (%sc) - %suse /gc modifier", |