diff options
author | Father Chrysostomos <sprout@cpan.org> | 2013-07-30 23:49:58 -0700 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2013-08-25 12:23:59 -0700 |
commit | 49f55535e0b402f8cbdf839b5f2c88306c91a31d (patch) | |
tree | 53d85774d91296f9ee177a27425e7be58dcf2dd7 /regexp.h | |
parent | a10eae290937db109954431d254a9a25287f190b (diff) | |
download | perl-49f55535e0b402f8cbdf839b5f2c88306c91a31d.tar.gz |
Stop substr re optimisation from rejecting long strs
Using I32 for the fields that record information about the location of
a fixed string that must be found for a regular expression to match
can result in match failures, because I32 is not large enough to store
offsets >= 2**31.
SSize_t is appropriate, since it is 64 bits on 64-bit platforms and 32
bits on 32-bit platforms.
This commit changes enough instances of I32 to SSize_t to get the
added test passing and suppress compiler warnings. A later commit
will change many more.
Diffstat (limited to 'regexp.h')
-rw-r--r-- | regexp.h | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -36,8 +36,8 @@ struct regexp_engine; struct regexp; struct reg_substr_datum { - I32 min_offset; - I32 max_offset; + SSize_t min_offset; + SSize_t max_offset; SV *substr; /* non-utf8 variant */ SV *utf8_substr; /* utf8 variant */ I32 end_shift; |