Move t/perl symlink creation back to the test_prep target of the Makefile

But not in the way it was done before with a recursive call to $(MAKE) -
instead create it directly in the current make invocation as an action for
test_prep, and create the link for perl.third directly as an action for
test_prep.third

Also, make it optional to pass the perl to run into runtests, by providing a
default of ./perl$(EXE_EXT)

This feels simpler and still Don't Repeat Yourself.

1 files changed, 5 insertions, 7 deletions

diff --git a/runtests.SH b/runtests.SH
index 1219bc04f5..7e417a37d9 100644
--- a/runtests.SH
+++ b/runtests.SH
@@ -28,11 +28,6 @@ case \$# in
 	;;
 esac
 
-if test X"\$PERL" = X; then
-    echo "please supply PERL in the environment"
-    exit 1
-fi
-
 case \$1 in
     tty)
 	tty=Y
@@ -57,9 +52,12 @@ if test X"\$TESTFILE" = X; then
     TESTFILE=TEST
 fi
 
+if test X"\$PERL" = X; then
+    PERL=./perl$_exe
+    export PERL
+fi
+
 cd t
-rm -f \$PERL
-$lns ../\$PERL \$PERL
 
 # The second branch is for testing without a tty or controlling terminal,
 # see t/op/stat.t