diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2013-08-10 10:38:08 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2013-08-11 10:53:34 -0700 |
| commit | 376ccf8b794f87b0c0a827bdcadc14b71179ff42 (patch) | |
| tree | ca5af59b5dad785ca07cdf8bfe0e7b72138960f5 /sv.c | |
| parent | 9bcf803b59623c817fbac6643ae044e77b2a5f38 (diff) | |
| download | perl-376ccf8b794f87b0c0a827bdcadc14b71179ff42.tar.gz | |
Make ++ handle regexps and vstrings
$ ./perl -Ilib -e 'use Devel::Peek; $x = v97; ++$x; Dump $x'
SV = PVMG(0x7fbfa402b698) at 0x7fbfa402eed8
REFCNT = 1
FLAGS = (RMG,POK,pPOK)
IV = 0
NV = 0
PV = 0x7fbfa3c066a8 "b"\0
CUR = 1
LEN = 24
MAGIC = 0x7fbfa3c06348
MG_VIRTUAL = 0
MG_TYPE = PERL_MAGIC_vstring(V)
MG_LEN = 3
MG_PTR = 0x7fbfa3c13ee8 "v97"
The vstring magic is still attached (with something that does not
match the contents of the string), even after modifying it. I
probably broke that in 5.18 after fixing it in 5.16, but I am too
lazy to check.
$ ./perl -le '$x = ${qr//}; $x++; print "$x"'
Assertion failed: (PL_valid_types_IVX[SvTYPE(_svivx) & SVt_MASK]), function Perl_sv_2pv_flags, file sv.c, line 2908.
Abort trap: 6
That I broke when I stopped regexps from being POK in perl 5.18.0.
It was creating a corrupt SV by setting the IOK flag on something of
type SVt_REGEXP.
Diffstat (limited to 'sv.c')
| -rw-r--r-- | sv.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -8268,8 +8268,6 @@ Perl_sv_inc_nomg(pTHX_ SV *const sv) if (!sv) return; if (SvTHINKFIRST(sv)) { - if (SvIsCOW(sv) || isGV_with_GP(sv)) - sv_force_normal_flags(sv, 0); if (SvREADONLY(sv)) { Perl_croak_no_modify(); } @@ -8281,6 +8279,7 @@ Perl_sv_inc_nomg(pTHX_ SV *const sv) sv_unref(sv); sv_setiv(sv, i); } + else sv_force_normal_flags(sv, 0); } flags = SvFLAGS(sv); if ((flags & (SVp_NOK|SVp_IOK)) == SVp_NOK) { |