Encourage compilers to tail call optimise in sv_savepv, sv_savepvn

and sv_savesharedpv. Need to create non-void returning versions of
Copy and Zero, as the existing macros deliberately cast to (void)

p4raw-id: //depot/perl@23126

1 files changed, 1 insertions, 2 deletions

diff --git a/sv.c b/sv.c
index 50501e7016..90793157ae 100644
--- a/sv.c
+++ b/sv.c
@@ -3742,9 +3742,8 @@ Perl_sv_2pv_flags(pTHX_ register SV *sv, STRLEN *lp, I32 flags)
 	*lp = len;
 	s = SvGROW(sv, len + 1);
 	SvCUR_set(sv, len);
-	(void)strcpy(s, t);
 	SvPOKp_on(sv);
-	return s;
+	return strcpy(s, t);
     }
 }