summaryrefslogtreecommitdiff
path: root/sv.c
diff options
context:
space:
mode:
authorTony Cook <tony@develop-help.com>2012-03-17 13:10:29 +1100
committerTony Cook <tony@develop-help.com>2012-12-09 09:32:46 +1100
commit265c4172cf0ecfa267652bbdb8e7fb7919f14656 (patch)
treea7331051fc71fed4c7f22cefc05b314aa66465c2 /sv.c
parenta1aea1fe12c11cc8f3650979df95e88a810f3238 (diff)
downloadperl-265c4172cf0ecfa267652bbdb8e7fb7919f14656.tar.gz
no need to FIXME, it behaves like read() which is the intent
except read() doesn't complain about the invalid characters like sv_gets().
Diffstat (limited to 'sv.c')
-rw-r--r--sv.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/sv.c b/sv.c
index 34dc534503..da10129802 100644
--- a/sv.c
+++ b/sv.c
@@ -7746,11 +7746,12 @@ S_sv_gets_read_record(pTHX_ SV *const sv, PerlIO *const fp, I32 append)
if (morebytesread <= 0) {
/* we're done, if we still have incomplete
characters the check code in sv_gets() will
- warn and zero them.
+ warn about them.
- FIXME: If we've read more than one lead
- character for an incomplete character, push
- it back.
+ I'd originally considered doing
+ PerlIO_ungetc() on all but the lead
+ character of the incomplete character, but
+ read() doesn't do that, so I don't.
*/
break;
}