summaryrefslogtreecommitdiff
path: root/t/io
diff options
context:
space:
mode:
authorFather Chrysostomos <sprout@cpan.org>2014-09-17 21:16:58 -0800
committerFather Chrysostomos <sprout@cpan.org>2014-11-02 18:23:43 -0800
commit96d7c88819733eaaba892177a967d9e898b2b924 (patch)
treedcc519ccc95d8fdc5e1c912e4b704da38d26f8a0 /t/io
parentf4725fad1a6349bcfadca13ee4398f61799a29d0 (diff)
downloadperl-96d7c88819733eaaba892177a967d9e898b2b924.tar.gz
[perl #57512] Warnings for implicitly closed handles
If the implicit close() fails, warn about it, mentioning $! in the message. This is a default warning in the io category. We do this in two spots, sv_clear and gp_free. While sv_clear would be sufficient to get the warning emitted, the warning won’t contain the name of the handle when called from there, because lone IO thing- ies are nameless. Doing it also when a GV’s glob pointer is freed--as long as the IO thingy in there has a reference count of 1--allows the name to be included in the message, because we still have the glob, which is where the name is stored. The result: $ ./miniperl -Ilib -e 'open fh, ">/Volumes/Disk Image/foo"; print fh "x"x1000, "\n" for 1..50; undef *fh' Warning: unable to close filehandle fh properly: No space left on device at -e line 1.
Diffstat (limited to 't/io')
-rw-r--r--t/io/eintr.t1
1 files changed, 1 insertions, 0 deletions
diff --git a/t/io/eintr.t b/t/io/eintr.t
index fd19b8aa8a..ca15232e69 100644
--- a/t/io/eintr.t
+++ b/t/io/eintr.t
@@ -69,6 +69,7 @@ plan(tests => 10);
# make two handles that will always block
sub fresh_io {
+ close $in if $in; close $out if $out;
undef $in; undef $out; # use fresh handles each time
pipe $in, $out;
$sigst = "";