Ensure that pp_qr returns a new regexp SV each time. Resolves RT #69852.

Instead of returning a(nother) reference to the (pre-compiled) regexp in the
optree, use reg_temp_copy() to create a copy of it, and return a reference to
that. This resolves issues about Regexp::DESTROY not being called in a timely
fashion (the original bug tracked by RT #69852), as well as bugs related to
blessing regexps, and of assigning to regexps, as described in correspondence
added to the ticket.

It transpires that we also need to undo the SvPVX() sharing when ithreads
cloning a Regexp SV, because mother_re is set to NULL, instead of a cloned
copy of the mother_re. This change might fix bugs with regexps and threads in
certain other situations, but as yet neither tests nor bug reports have
indicated any problems, so it might not actually be an edge case that it's
possible to reach.

1 files changed, 0 insertions, 4 deletions

diff --git a/t/re/qr_gc.t b/t/re/qr_gc.t
index db2e96ed2c..ca82f420ef 100644
--- a/t/re/qr_gc.t
+++ b/t/re/qr_gc.t
@@ -9,10 +9,6 @@ BEGIN {
 
 plan tests => 2;
 
-if ($] >= 5.011) { # doesn't leak on 5.10.x
-    $TODO = "leaking since 32751";
-}
-
 my $destroyed;
 {
     sub Regexp::DESTROY { $destroyed++ }