Restore ‘Can’t localize through ref’ to lv subs

In commit 40c94d11, I put an if statement inside an if statement,
skipping the else that followed if the outer if was true:

  if (...) {

  }
  else if {

became

  if (...) {
     ...
     if (...) {
        ...
     }
  }
  else if {

The result was that ‘Can’t localize through a reference’ no longer
happened if the operator (%{} or @{}) was the last thing in an lvalue
sub, if the lvalue sub was not called in lvalue context.

$ perl5.14.0 -e 'sub foo :lvalue { local %{\%foo} } foo(); print "ok\n"'
Can't localize through a reference at -e line 1.
$ perl5.16.0 -e 'sub foo :lvalue { local %{\%foo} } foo(); print "ok\n"'
ok

If the sub is called in lvalue context, the bug exists there, too, but
is much older (probably 82d039840b9):

$ perl5.6.2 -e 'sub f :lvalue { local %{\%foo} } (f()) =3; print "ok\n"'
Can't localize through a reference at -e line 1.
$ perl5.8.1 -e 'sub f :lvalue { local %{\%foo} } (f()) =3; print "ok\n"'
ok

The simplest solution is to change the order of the conditions.  If
the rv2hv or rv2av op is passed a reference, and has ‘local’ in front
of it (OPf_MOD && OPpLVAL_INTRO), that should die, regardless of
whether it is the last thing in an lvalue sub.

1 files changed, 24 insertions, 0 deletions

diff --git a/t/lib/croak/pp_hot b/t/lib/croak/pp_hot
index 0b65d7cd6b..6b59ba7879 100644
--- a/t/lib/croak/pp_hot
+++ b/t/lib/croak/pp_hot
@@ -1,4 +1,28 @@
 __END__
+# NAME local %$ref on last line of lvalue sub in lv cx
+   sub foo :lvalue { local %{\%foo} }
+   (foo) = 3;
+EXPECT
+Can't localize through a reference at - line 1.
+########
+# NAME local @$ref on last line of lvalue sub in lv cx
+   sub foo :lvalue { local @{\@foo} }
+   (foo) = 3;
+EXPECT
+Can't localize through a reference at - line 1.
+########
+# NAME local %$ref on last line of lvalue sub in non-lv cx
+   sub foo :lvalue { local %{\%foo} }
+   foo;
+EXPECT
+Can't localize through a reference at - line 1.
+########
+# NAME local @$ref on last line of lvalue sub in non-lv cx
+   sub foo :lvalue { local @{\@foo} }
+   foo;
+EXPECT
+Can't localize through a reference at - line 1.
+########
 # NAME calling undef sub belonging to undef GV
    my $foosub = \&foo;
    undef *foo;