diff options
| author | Jan Dubois <jand@activestate.com> | 2010-10-25 15:50:27 -0700 |
|---|---|---|
| committer | Jan Dubois <jand@activestate.com> | 2010-10-25 15:59:49 -0700 |
| commit | 60b22aca14742ead2388ca3c7bb4b542a2d9a4b1 (patch) | |
| tree | 16381f46b798b66e9e1507ba4aff1c54d2488c7d /t | |
| parent | 0936ef8b60a303fb904c7a44b7e4f55e8191503c (diff) | |
| download | perl-60b22aca14742ead2388ca3c7bb4b542a2d9a4b1.tar.gz | |
Implement DIR* cloning on Windows
There doesn't seem to be a mechanism to clone FileFind handles on
Windows. Therefore this implementation just reads all remaining
entries into a cache buffer and closes the handle. All further
readdir() requests will be fulfilled from the cache buffer, in both
the original and the new interpreter.
This fixes bug 75154 on Windows (all tests in t/op/threads-dirh.t pass).
This commit also changes the return value of win32_telldir() to -1
for directory handles that have been read until the end. The previous
return value was (NULL - dirp->start), which technically is not
valid C code.
API change alert: Perl_dirp_dup() gets an additional CLONE_PARAMS
parameter in this change (like all the other Perl_*_dup() functions).
Diffstat (limited to 't')
| -rw-r--r-- | t/op/threads-dirh.t | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/op/threads-dirh.t b/t/op/threads-dirh.t index 2e05f5d669..d207bc4835 100644 --- a/t/op/threads-dirh.t +++ b/t/op/threads-dirh.t @@ -45,8 +45,8 @@ SKIP: { skip $_[0], 5 }; - if(!$Config::Config{d_fchdir}) { - $::TODO = 'dir handle cloning currently requires fchdir'; + if(!$Config::Config{d_fchdir} && $^O ne "MSWin32") { + $::TODO = 'dir handle cloning currently requires fchdir on non-Windows platforms'; } my @w :shared; # warnings accumulator |