Add strict and warnings to t/op/for.t

strict subs and refs, but not strict vars, because it's obvious that some
tests are explicitly about package variables, but it's not obvious whether
what they are testing is sensitive to rewriting the variables with full
package names.

Also convert it to done_testing(), and add a call to set_up_inc().

1 files changed, 11 insertions, 3 deletions

diff --git a/t/op/for.t b/t/op/for.t
index f34fbd8b56..d199cc8a82 100644
--- a/t/op/for.t
+++ b/t/op/for.t
@@ -3,9 +3,11 @@
 BEGIN {
     chdir 't' if -d 't';
     require "./test.pl";
+    set_up_inc('../lib');
 }
 
-plan(126);
+use strict qw(subs refs);
+use warnings;
 
 # A lot of tests to check that reversed for works.
 
@@ -548,12 +550,16 @@ for my $i (reverse (map {$_} @array, 1)) {
 }
 is ($r, '1CBA', 'Reverse for array and value via map with var');
 
-is do {17; foreach (1, 2) { 1; } }, '', "RT #1085: what should be output of perl -we 'print do { foreach (1, 2) { 1; } }'";
+{
+    no warnings 'void';
+    is (do {17; foreach (1, 2) { 1; } }, "",
+        "RT #1085: what should be output of perl -we 'print do { foreach (1, 2) { 1; } }'");
+}
 
 TODO: {
     local $TODO = "RT #2166: foreach spuriously autovivifies";
     my %h;
-    foreach (@h{a, b}) {}
+    foreach (@h{'a', 'b'}) {}
     is keys(%h), 0, 'RT #2166: foreach spuriously autovivifies';
 }
 
@@ -678,3 +684,5 @@ is(fscope(), 1, 'return via loop in sub');
     push @b, $_ for (reverse 'bar');
     is "@b", "bar", " RT #133558 reverse list";
 }
+
+done_testing();