don't check format args on taint_proper

My recent commit 5d37acd6b65eb enabled (among other things)
format-arg checking of taint_proper(). This was not a good idea since
taint_proper() adds extra args before it actually calls a printf-style
function. This was masked since on some gcc systems, a NULLOK format arg
disables this check.

1 files changed, 4 insertions, 1 deletions

diff --git a/taint.c b/taint.c
index 63f0dfccd3..3fc62507ca 100644
--- a/taint.c
+++ b/taint.c
@@ -55,7 +55,10 @@ Perl_taint_proper(pTHX_ const char *f, const char *const s)
         else
 	    ug = " while running with -T switch";
 
-        GCC_DIAG_IGNORE(-Wformat-nonliteral); /* fmt checked by caller */
+        /* XXX because taint_proper adds extra format args, we can't
+         * get the caller to check properly; o we just silence the warning
+         * and hope the callers aren't naughty */
+        GCC_DIAG_IGNORE(-Wformat-nonliteral);
 	if (PL_unsafe || TAINT_WARN_get) {
 	    Perl_ck_warner_d(aTHX_ packWARN(WARN_TAINT), f, s, ug);
         }