diff options
author | David Mitchell <davem@iabyn.com> | 2010-04-15 10:20:50 +0100 |
---|---|---|
committer | David Mitchell <davem@iabyn.com> | 2010-04-15 10:32:59 +0100 |
commit | f2338a2e8347fc967ab6b9af21d948258b88e341 (patch) | |
tree | ac9b735cf41f4c61d74904471fdbdd84297fdeeb /toke.c | |
parent | db63319f533e643ef6aac622fcae9a2f7ceabb0d (diff) | |
download | perl-f2338a2e8347fc967ab6b9af21d948258b88e341.tar.gz |
use cBOOL for bool casts
bool b = (bool)some_int
doesn't necessarily do what you think. In some builds, bool is defined as
char, and that cast's behaviour is thus undefined. So this line in mg.c:
const bool was_temp = (bool)SvTEMP(sv);
was actually setting was_temp to false even when the SVs_TEMP flag was set.
Fix this by replacing all the (bool) casts with a new cBOOL() cast macro
that (hopefully) does the right thing.
Diffstat (limited to 'toke.c')
-rw-r--r-- | toke.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -13700,7 +13700,7 @@ S_utf16_textfilter(pTHX_ int idx, SV *sv, int maxlen) SV *const utf16_buffer = MUTABLE_SV(IoTOP_GV(filter)); SV *const utf8_buffer = filter; IV status = IoPAGE(filter); - const bool reverse = (bool) IoLINES(filter); + const bool reverse = cBOOL(IoLINES(filter)); I32 retval; /* As we're automatically added, at the lowest level, and hence only called |