diff options
| author | Daniel Dragan <bulk88@hotmail.com> | 2012-11-12 00:04:00 -0500 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2012-11-12 06:17:36 -0800 |
| commit | cb077ed29694c30e42772d2c1fc2d9a9b3183eca (patch) | |
| tree | d8af4ba26da3f83b7425214465b2c7d6fc28dd3b /universal.c | |
| parent | 18c931a3833eccac01983e3e50239ca36de82ec4 (diff) | |
| download | perl-cb077ed29694c30e42772d2c1fc2d9a9b3183eca.tar.gz | |
rmv context from Perl_croak_no_modify and Perl_croak_xs_usage
Remove the context/pTHX from Perl_croak_no_modify and Perl_croak_xs_usage.
For croak_no_modify, it now has no parameters (and always has been
no return), and on some compilers will now be optimized to a conditional
jump. For Perl_croak_xs_usage one push asm opcode is removed at the caller.
For both funcs, their footprint in their callers (which probably are hot
code) is smaller, which means a tiny bit more room in the cache. My text
section went from 0xC1A2F to 0xC198F after apply this. Also see
http://www.nntp.perl.org/group/perl.perl5.porters/2012/11/msg195233.html .
Diffstat (limited to 'universal.c')
| -rw-r--r-- | universal.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/universal.c b/universal.c index 055d8ab176..8cc6e63a93 100644 --- a/universal.c +++ b/universal.c @@ -298,7 +298,7 @@ C<croak()>. Hence if C<cv> is C<&ouch::awk>, it would call C<croak> as: */ void -Perl_croak_xs_usage(pTHX_ const CV *const cv, const char *const params) +Perl_croak_xs_usage(const CV *const cv, const char *const params) { const GV *const gv = CvGV(cv); @@ -308,16 +308,16 @@ Perl_croak_xs_usage(pTHX_ const CV *const cv, const char *const params) const HV *const stash = GvSTASH(gv); if (HvNAME_get(stash)) - Perl_croak(aTHX_ "Usage: %"HEKf"::%"HEKf"(%s)", + Perl_croak_nocontext("Usage: %"HEKf"::%"HEKf"(%s)", HEKfARG(HvNAME_HEK(stash)), HEKfARG(GvNAME_HEK(gv)), params); else - Perl_croak(aTHX_ "Usage: %"HEKf"(%s)", + Perl_croak_nocontext("Usage: %"HEKf"(%s)", HEKfARG(GvNAME_HEK(gv)), params); } else { /* Pants. I don't think that it should be possible to get here. */ - Perl_croak(aTHX_ "Usage: CODE(0x%"UVxf")(%s)", PTR2UV(cv), params); + Perl_croak_nocontext("Usage: CODE(0x%"UVxf")(%s)", PTR2UV(cv), params); } } |