diff options
author | Father Chrysostomos <sprout@cpan.org> | 2012-05-24 22:19:29 -0700 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2012-06-07 08:18:51 -0700 |
commit | 5c5c5f453ae0dda3c851bdfad81fe7b65fe7fbc7 (patch) | |
tree | 2766b5cd5bd849fd177f275f720cecb092d21f12 /util.c | |
parent | 0223a80133899e1c84be7768d5224ee894e33c6f (diff) | |
download | perl-5c5c5f453ae0dda3c851bdfad81fe7b65fe7fbc7.tar.gz |
util.c:report_evil_fh: Rmv redundant isGV check
Checking isGV_with_GP makes the isGV check redundant. The only case
in which isGV could be true when isGV_with_GP is false could be a GV
playing PVBM, but those don’t exist any more. When they did exist,
this check was probably wrong (and crashable).
Diffstat (limited to 'util.c')
-rw-r--r-- | util.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -3751,7 +3751,7 @@ Perl_report_evil_fh(pTHX_ const GV *gv) if (ckWARN(warn_type)) { SV * const name - = gv && (isGV(gv) || isGV_with_GP(gv)) && GvENAMELEN(gv) ? + = gv && isGV_with_GP(gv) && GvENAMELEN(gv) ? sv_2mortal(newSVhek(GvENAME_HEK(gv))) : NULL; const char * const pars = (const char *)(OP_IS_FILETEST(op) ? "" : "()"); |