summaryrefslogtreecommitdiff
path: root/util.c
diff options
context:
space:
mode:
authorIlya Zakharevich <ilya@math.berkeley.edu>1998-02-25 21:47:46 -0500
committerMalcolm Beattie <mbeattie@sable.ox.ac.uk>1998-02-27 15:26:45 +0000
commitc2267164204a961273c71c9c103831895724b0b1 (patch)
treee1be7d708a8588e9df821cc20be5a32e5ac3493a /util.c
parent4e2a5f63925503b57176e32249cf6e160bcf9be9 (diff)
downloadperl-c2267164204a961273c71c9c103831895724b0b1.tar.gz
Fix file-descriptor leak when pipes fail via taint checks:
Subject: [PATCH] Some patches went through cracks p4raw-id: //depot/perl@593
Diffstat (limited to 'util.c')
-rw-r--r--util.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/util.c b/util.c
index 0dd944333f..770aa29419 100644
--- a/util.c
+++ b/util.c
@@ -1855,14 +1855,14 @@ my_popen(char *cmd, char *mode)
return my_syspopen(cmd,mode);
}
#endif
- if (PerlProc_pipe(p) < 0)
- return Nullfp;
This = (*mode == 'w');
that = !This;
if (doexec && tainting) {
taint_env();
taint_proper("Insecure %s%s", "EXEC");
}
+ if (PerlProc_pipe(p) < 0)
+ return Nullfp;
while ((pid = (doexec?vfork():fork())) < 0) {
if (errno != EAGAIN) {
PerlLIO_close(p[This]);