diff options
author | Father Chrysostomos <sprout@cpan.org> | 2012-05-24 22:10:32 -0700 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2012-06-07 08:18:51 -0700 |
commit | c6e4ff343b63c6923b5be105aa9e384e8176673a (patch) | |
tree | b70bd4ac0222961e397fe9a8fea247d7cb6f64c5 /util.c | |
parent | cee59a6aac1243619d4052d0291981c8f2a9966d (diff) | |
download | perl-c6e4ff343b63c6923b5be105aa9e384e8176673a.tar.gz |
util.c:report_wrongway_fh: Rmv redundant isGV check
Checking isGV_with_GP makes the isGV check redundant. The only case
in which isGV could be true when isGV_with_GP is false could be a GV
playing PVBM, but those don’t exist any more. When they did exist,
this check was probably wrong (and crashable).
Diffstat (limited to 'util.c')
-rw-r--r-- | util.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -3717,7 +3717,7 @@ Perl_report_wrongway_fh(pTHX_ const GV *gv, const char have) { if (ckWARN(WARN_IO)) { SV * const name - = gv && (isGV(gv) || isGV_with_GP(gv)) + = gv && (isGV_with_GP(gv)) ? sv_2mortal(newSVhek(GvENAME_HEK((gv)))) : NULL; const char * const direction = have == '>' ? "out" : "in"; |