summaryrefslogtreecommitdiff
path: root/util.c
diff options
context:
space:
mode:
authorJarkko Hietaniemi <jhi@iki.fi>2003-08-12 13:15:17 +0000
committerJarkko Hietaniemi <jhi@iki.fi>2003-08-12 13:15:17 +0000
commit54fe902f9886cc8f30bf23406997db45be0fb8d6 (patch)
treec6ee3df35c2b0d6029ef56d9b3103c6276df0f8b /util.c
parent8fd8d6f4c19523f1ce788a39bce2791a00534fad (diff)
downloadperl-54fe902f9886cc8f30bf23406997db45be0fb8d6.tar.gz
Retract #20644 and #20643; on non-microperl non-fcntl
systems Wrong Thing would be done. (And as Sarathy points out, closing both ends of a pipe is rather identical to never opening it...) p4raw-id: //depot/perl@20653
Diffstat (limited to 'util.c')
-rw-r--r--util.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/util.c b/util.c
index cec92e2635..aec43548f6 100644
--- a/util.c
+++ b/util.c
@@ -1821,8 +1821,6 @@ Perl_my_popen_list(pTHX_ char *mode, int n, SV **args)
#if defined(HAS_FCNTL) && defined(F_SETFD)
/* Close error pipe automatically if exec works */
fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
- PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
#endif
}
/* Now dup our end of _the_ pipe to right position */
@@ -1962,8 +1960,6 @@ Perl_my_popen(pTHX_ char *cmd, char *mode)
PerlLIO_close(pp[0]);
#if defined(HAS_FCNTL) && defined(F_SETFD)
fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
- PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
#endif
}
if (p[THIS] != (*mode == 'r')) {