diff options
| author | Nicolas R <atoomic@cpan.org> | 2020-06-16 11:05:17 -0600 |
|---|---|---|
| committer | Karl Williamson <khw@cpan.org> | 2020-08-10 22:28:04 -0600 |
| commit | 188e64dde7746219802c1eafb9ef48df31f65f0d (patch) | |
| tree | 1ab704cd8389e5c5eb54967c07342b12f5cc140e /utils/piconv.PL | |
| parent | ab01742544b98b5b5e13d8e1a6e9df474b9e3005 (diff) | |
| download | perl-188e64dde7746219802c1eafb9ef48df31f65f0d.tar.gz | |
Provide a better recommendation for 'Run only under a shell'
Using an unset variable hides the true intent and
also requires an extra backslash `\$running_under_some_shell`
when used in heredoc.
Note that this could also lead to mistake when using
`\$` in a regular Perl program, as this would be true
and not false as it should be.
Stop recommending the use of an undefined variable for
the shell fallback. Use '0', with a comment
making clear the goal of 'if 0'.
Diffstat (limited to 'utils/piconv.PL')
| -rw-r--r-- | utils/piconv.PL | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/piconv.PL b/utils/piconv.PL index 4e012d3dc3..7be2196809 100644 --- a/utils/piconv.PL +++ b/utils/piconv.PL @@ -28,7 +28,7 @@ print "Extracting $file (with variable substitutions)\n"; print OUT <<"!GROK!THIS!"; $Config{startperl} eval 'exec $Config{perlpath} -S \$0 \${1+"\$@"}' - if \$running_under_some_shell; + if 0; # ^ Run only under a shell !GROK!THIS! use File::Spec; |