summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--doop.c3
-rwxr-xr-xt/op/bop.t13
2 files changed, 14 insertions, 2 deletions
diff --git a/doop.c b/doop.c
index 8733816890..c23093caf0 100644
--- a/doop.c
+++ b/doop.c
@@ -1174,7 +1174,7 @@ Perl_do_vop(pTHX_ I32 optype, SV *sv, SV *left, SV *right)
}
else if (SvOK(sv) || SvTYPE(sv) > SVt_PVMG) {
dc = SvPV_force_nomg_nolen(sv);
- if (SvCUR(sv) < (STRLEN)len) {
+ if (SvLEN(sv) < (STRLEN)(len + 1)) {
dc = SvGROW(sv, (STRLEN)(len + 1));
(void)memzero(dc + SvCUR(sv), len - SvCUR(sv) + 1);
}
@@ -1303,6 +1303,7 @@ Perl_do_vop(pTHX_ I32 optype, SV *sv, SV *left, SV *right)
case OP_BIT_AND:
while (len--)
*dc++ = *lc++ & *rc++;
+ *dc = '\0';
break;
case OP_BIT_XOR:
while (len--)
diff --git a/t/op/bop.t b/t/op/bop.t
index 87291676ef..6bc1067cc2 100755
--- a/t/op/bop.t
+++ b/t/op/bop.t
@@ -15,7 +15,7 @@ BEGIN {
# If you find tests are failing, please try adding names to tests to track
# down where the failure is, and supply your new names as a patch.
# (Just-in-time test naming)
-plan tests => 146;
+plan tests => 148;
# numerics
ok ((0xdead & 0xbeef) == 0x9ead);
@@ -329,3 +329,14 @@ SKIP: {
skip "No malloc wrap checks" unless $Config::Config{usemallocwrap};
like( runperl(prog => 'eval q($#a>>=1); print 1'), "^1\n?" );
}
+
+# [perl #37616] Bug in &= (string) and/or m//
+{
+ $a = "aa";
+ $a &= "a";
+ ok($a =~ /a+$/, 'ASCII "a" is NUL-terminated');
+
+ $b = "bb\x{100}";
+ $b &= "b";
+ ok($b =~ /b+$/, 'Unicode "b" is NUL-terminated');
+}