summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* (3) File::Find::find()/finddepth() bugs with toplevel pathsConrad E. Kimball1997-08-071-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The File::Find module exhibits the following defects: 1) If the top-level directory is a symbolic link to another directory, the find() and finddepth() functions follow that symbolic link and traverse that directory. This behavior is both contrary to the way the real find command works and contrary to the way find() and finddepth() treat symbolic links that occur lower down in the directory hierarchy (which aren't followed). Example: $ cd $HOME $ mkdir findbug; cd findbug $ ln -s /usr usr $ find usr -print usr $ find2perl usr -print | perl usr usr/lost+found usr/tmp usr/tmp/.zma25637cbbb ... 2) If the wanted() function sets $prune = 1 for a toplevel directory, the find() function ignores it. It honors $prune for all lower level directories, but not the toplevel ones. This, too, is contrary to the way the real find command works. Example: $ find /usr -print -prune /usr $ find2perl /usr -print -prune | perl /usr /usr/lost+found /usr/tmp /usr/bin /usr/man /usr/etc /usr/lib /usr/netdemo /usr/include /usr/adm ... 3) If finddepth() is passed a toplevel path that is not a directory, it fails to set $name before calling the wanted() function. This, too, is contrary to the way the real find command works. Example: $ cd $HOME $ find /dev/null -depth -print /dev/null $ find2perl /dev/null -depth -print | perl $ The following patch corrects all three defects: p5p-msgid: 199707040045.RAA24459@mailgate2.boeing.com
* posix.xs broken on VMS 7.1Dan Sugalski1997-08-071-5/+6
| | | | private-msgid: 3.0.2.32.19970718095755.00875ba0@stargate.lbcc.cc.or.us
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * pod2html mangles C<&foo(42);>Hans Mulder1997-08-071-1/+1
| | | | | | | | | | | | | | | | Pod2html does not handle ampersands inside C<> sequences properly. For example, C<&foo(42);> is translated to <CODE>&foo(42);</CODE>. This is wrong: the "&" needs to be translated to "&amp;". p5p-msgid: 199706250057.CAA10162@xs1.xs4all.nl
* | pod2html mangles C<&foo(42);>Tim Bunce1997-08-071-2/+2
|/ | | | (this is the same change as commit cbcd949909e8235878afef51bf24ea843fcacde0, but as applied)
* Allow concurrent mkdir in File::Path::mkpathRuben Schattevoy1997-08-071-1/+4
| | | | private-msgid: 199707300943.LAA21574@kant.imb-jena.de
* icmp tweak for IO::SocketNick Ing-Simmons1997-08-071-1/+2
| | | | | | | | | | | Following patch allows use of : my $sock = IO::Socket::INET->new(Proto => 'icmp'); To create an ICMP protocol socket, as use for traditional 'ping'. On UNIX at least only super-user can do this. p5p-msgid: 199707041240.NAA21484@pluto.tiuk.ti.com
* ExtUtils-Embed upgradeDoug MacEachern1997-08-071-11/+18
|
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * Sys::Syslog patch to allow unix domain socketsSean Robinson1997-08-071-10/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thank you to Tim Bunce and Tom Phoenix for insights on making the patched code faster and safer, and pointing out bugs. What follows is a "fresh patch over the 5.004_01 version". So reverse the previous patch before adding this one just to be safe. CHANGES (all recommended by Tim or Tom): - fixed bug where wrong variable was undef()ined causing attempts to change back to INET socket to never occur - setlogsock() now croaks on any value other than 'unix' or 'inet' - setlogsock() no longer uses pattern matching, but is still case-insensitive - updated documentation p5p-msgid: 33B31342.7EB16A44@sc.maricopa.edu
* | Sys::Syslog patch to allow unix domain socketsTim Bunce1997-08-071-8/+44
|/ | | | (this is the same change as commit 8297ae023be5d5af05b2a7f966169444314ba5aa, but as applied)
* Net::hostent documentation errorNat Torkington1997-08-071-3/+3
| | | | | | perl -pi -e 's/addresses/addr_list/g' .../Net/hostent.pm p5p-msgid: 199707082222.QAA24728@elara.frii.com
* IO::File and DB_File pollutes namespace with Fcntl constantsGisle Aas1997-08-071-15/+8
| | | | private-msgid: h205qyijy.fsf@bergen.sn.no
* Problems with setvbufIlya Zakharevich1997-08-071-0/+2
| | | | | | | | | | | | | | Nick Ing-Simmons writes: > > I see two possible solutions: > > > > a) correct this on the level of IO.xs (manually check for > > IoIFP(sv_2io(ST(0))); > > I like adding this code to the else branch. This is almost as you ask: p5p-msgid: 199707250040.UAA11000@monk.mps.ohio-state.edu
* xsubpp patchJohn Tobey1997-08-071-24/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The patch below is against the 5.004_01 distribution's xsubpp and incorporates your changes. > From: Gurusamy Sarathy <gsar@engin.umich.edu> > > On Mon, 30 Jun 1997 03:16:25 EDT, Ilya Zakharevich wrote: > >John Tobey sent me a remarkable fix for xsubpp bugs with #line > >directives. I did check a previous version of his patch, and it > >worked flawlessly, with the only drawback that it did not #line'ized > >BOOT directives. > > > >Today I got his next version, and he claims it now handles BOOT too. > >I think it may go even to the maintainance track. > > Not until the issues below are resolved. I've attached a patch > that fixes all but one. I believe it's possible to avoid any subprocesses or shell invocations by using a tied filehandle. Getting the output filename right will require restructuring xsubpp's command line interface and changing MakeMaker, whence my ".c" hack. Given that the previous xsubpp didn't insert any self-pointing line directives, I figure it's a gain, though by no means perfect. The tie idea may improve portability at the expense of length and complexity. It's worked in my test cases (unlike my last patch, in which C<splice(@BootCode, 1)> should be C<@BootCode> as you noticed). However, I feel I'm on thin ice when using TIEHANDLE, and this code can certainly be smoothed out a bit. p5p-msgid: 199707010221.CAA01234@remote133
* Docs of IO::Handle [PATCH]Ilya Zakharevich1997-08-071-1/+3
| | | | | | | | I was caught by the following errors in documentation: Enjoy, p5p-msgid: 199707222307.TAA08380@monk.mps.ohio-state.edu
* m2t2 broke CPAN.pm :-(Andreas J. Koenig1997-08-074-433/+606
|
* m2t3: minor doc patch (to obsolete I18N::Collate)Jarkko Hietaniemi1997-08-071-11/+25
| | | | p5p-msgid: 199708060732.KAA02675@alpha.hut.fi
* [BUG:PATCH] dumpvar.pl parses some references incorrectlyM.J.T. Guy1997-08-071-7/+7
| | | | | | | | | | | | | dumpvar.pl parses stringified references incorrectly when extrovert class names are used. For example, x bless {}, '=ARRAY(' will crash the debugger. Patch (for 5.004_01 or 5.004_02) attached. p5p-msgid: E0wwAjQ-0004l6-00@ursa.cus.cam.ac.uk
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * confessing a carpNick Ing-Simmons1997-08-071-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tim Bunce wrote: > > I'd like to be able to use, or tell people to use, a simple command like: > > PERL_CONFESS=1 bad_script.pl Does not work for csh folk - they have to do use env or do setenv. > or > perl -MCarpConfess bad_script.pl This is a bit like -Mblib - pragma-ish so how about perl -Mconfess bad_script.pl > [...] > Note that the whole point is to have a global effect so an alternate Carp > module would not be appropriate. > > I think I prefer the very small change to Carp.pm. I think I prefer the very small auxillary module: Credited: Hugo van der Sanden <hv@crypt.compulink.co.uk> Credited: Tim Bunce <Tim.Bunce@ig.co.uk> p5p-msgid: 33E79BE2.4E6F@ni-s.u-net.com
* | confessing a carpTim Bunce1997-08-071-4/+38
|/ | | | (this is the same change as commit 948f37eb18dbace1def87d7f9339a75821436acd, but as applied)
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * Warning from calls using "use Shell"Andrew Pimlott1997-08-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Mon, 28 Jul 1997 15:35:46 -0400 (EDT), Thomas Lowery <nab2337@dsacnhp1.dsac.dla.mil> wrote: > >Following an example from the perldoc Shell produces the following >warning messages. How do I avoid the warning? > >Variable "$cmd" will not stay shared at (eval 1) line 14. >Variable "$cmd" will not stay shared at (eval 2) line 14. Under 5.004, Shell.pm triggers this warning for every sub it autoloads. I didn't see any response to this message, so here is a simple patch. It just makes the named sub an anonymous sub assigned to a glob, suppressing the warning. Credited: Andrew Pimlott <andrew@pimlott.student.harvard.edu> p5p-msgid: 199708061739.NAA14754@pimlott.student.harvard.edu private-msgid: Pine.SOL.3.91.970806173903.7320H-100000@abel
* | Warning from calls using "use Shell"Tim Bunce1997-08-071-1/+1
|/ | | | (this is the same change as commit a5bda13b0ef005fbbd13265a362caff51359bbc6, but as applied)
* splitpod broken in 5.004_01Tim Bunce1997-08-071-3/+9
| | | | | | | | | | | | | > From: Hans Mulder <hansmu@xs4all.nl> > > Splitpod is broken in 5.004_01. Darn, my fault. Thanks for this and your other bug reports. I guess _02 will be sooner rather than later. p5p-msgid: 9706241612.AA09119@toad.ig.co.uk
* Document use of - in a regex char class.Dominic Dunlop1997-08-071-1/+5
| | | | | | | | | | | | | | | | | | | | | Subject: [PATCH] Re: regex matcher incorrect At 13:17 +0200 1997-06-24, Ulrich Windl wrote: >In a statement like "$_[0] =~ /^([ugoa]+)([+-=])([rwxst]*)$/;" some >incorrect patterns were matched. As an example "go/rw" was matched. >Adding a backslash in front of the minus, making "[+\-=]", solved the >problem. > >As this is a non-obvious feature, I'd consider that as a bug. Originally >the problem was seen on Linux running the same version of Perl. Thanks Ulrich. You're right. While all UNIX-descended regular expression packages work pretty much the same way in respect how you make "-" a member of a character class, neither the documentation delivered with Perl nor the book "Programming Perl" tells you what to do, and they should. Here's a patch to apply to the perlre.pod documentation file: p5p-msgid: v03102804afd578bcef2c@[194.51.248.88]
* done3/perlbook.podRandal Schwartz1997-08-071-14/+10
|
* arguments swapped in perlapio.podHans Mulder1997-08-071-2/+2
| | | | | | | Three PerlIO functions have their arguments swapped (compared with their stdio counterparts). Perlapio.pod gets this almost right: p5p-msgid: 199706240049.CAA10534@xs2.xs4all.nl
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * [BUG:47:LOG] Dropped "and" in pod2manHans Mulder1997-08-071-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nathan Torkington wrote: > perlfunc.pod contains: > For a yet-more-powerful import facility, see L</use> and > L<perlmod>. > when pod2man | nroff -man has its way with this, it comes out as: > For a yet-more-powerful import facility, see the > use entry elsewhere in this document the perlmod > manpage. > That is, the "and" is dropped. I've verified this with the pod2man > that comes with 5.004_01, but I couldn't produce a simple test case in > 30 seconds. This is about as simple as I could produce in 50 seconds: =head1 NAME foo - bar =head1 DESCRIPTION L</foo> and bar This seems to help: p5p-msgid: 9707082355.AA13254@ icgned.icgned.nl private-msgid: 9707082355.AA13254@icgned.icgned.nl
* | [BUG:47:LOG] Dropped "and" in pod2manTim Bunce1997-08-071-3/+5
|/ | | | (this is the same change as commit 5d3b0638f4c2cf44af3831abe68fc08048b89bc2, but as applied)
* Major goof in XS Tutorial regarding subdirsIlya Zakharevich1997-08-071-2/+2
| | | | | | | | | | Subject: [PATCH] Major goof in XS Tutorial (subdirs) I wondered for a lot of time why I never manage to compile extensions with debugging enabled if the main Perl library is optimized. Some time ago I understood that this is due to the following error in XS tutorial: p5p-msgid: 199707260920.FAA12453@monk.mps.ohio-state.edu
* object never destructsGurusamy Sarathy1997-08-072-5/+22
| | | | | | | | | | | | | | | | | | | | | | | | | On Sun, 13 Jul 1997 11:20:24 EDT, Andrew Pimlott wrote: >package mytest; >sub DESTROY { warn "Death"; } >package main; >{ > my $joe; > my $moe; > $moe = bless \$joe, 'mytest'; > print "Leaving block\n"; >} >print "Left block\n"; Thanks for that excellent test case. Perl optimizes the memory management of lexicals by not actually deallocating unreferenced lexicals when the block exits, in order to reuse them when the block is reentered. This of course fails to destruct objects at the end of blocks. A patch that fixes the problem for all object datatypes is attached. p5p-msgid: 199707131955.PAA29655@aatma.engin.umich.edu
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * : reduced malloc patchIlya Zakharevich1997-08-074-13/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since this problems arise again and again on the list, here is the reduced malloc patch. It corrects the following problems: a) several off-by-one in av_make(); b) Growing TMP on conversion number=>string; c) Uncompatibility of -DDEBUGGING_MSTATS and system malloc; (The first two problems are fixed by malloc_jumbo_2 as well, but the 2 chunks for "c" - in perl.c - were forgotten in that patch). Enjoy, p5p-msgid: 199707150829.EAA01291@monk.mps.ohio-state.edu
* | : reduced malloc patchTim Bunce1997-08-071-10/+12
|/ | | | (this is the same change as commit 38a1ac3f7341206073b47f38b6bdb094f3f50352, but as applied)
* Constant-fold sprintf()Chip Salzenberg1997-08-071-1/+1
|
* [dummy merge]Tim Bunce1997-08-070-0/+0
|\ | | | | | | | | This merge exists so that the p5p version of the patch and the applied version are both in the history
| * Don't use undef value in Config::myconfigAndreas J. Koenig1997-08-071-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Subject: Config->myconfig not -w clean Thanks to a report by Larry Virden I spotted a bug in Config.pm. Undefined values trigger "Use of undefined value" messages, e.g. # perl -MConfig -we 'print Config->myconfig' Use of uninitialized value at /usr/local/lib/perl5/IP22-irix/5.004/Config.pm line 553. Use of uninitialized value at /usr/local/lib/perl5/IP22-irix/5.004/Config.pm line 553. Use of uninitialized value at /usr/local/lib/perl5/IP22-irix/5.004/Config.pm line 553. Use of uninitialized value at /usr/local/lib/perl5/IP22-irix/5.004/Config.pm line 553. Summary of my perl5 (5.0 patchlevel 4 subversion 0) configuration: Platform: [...] I'd suggest this simple patch: Credited: Chip Salzenberg <salzench@nielsenmedia.com> p5p-msgid: 199706271525.RAA13517@sissy.in-berlin.de
* | Don't use undef value in Config::myconfigTim Bunce1997-08-071-1/+2
|/ | | | (this is the same change as commit 754da6387aaed7d7ca907de8ac487143097ad5e3, but as applied)
* [differences between cumulative patch application and perl5.004_01]perl-5.004_01Tim Bunce1997-06-1192-3330/+2775
|\ | | | | | | | | | | | | | | | | [editor's note: The changes between this and 5.004 were processed from the m1t2 release, which was a bad idea as it was the _01 release which had the final corrected attributions. The differences between the various m*t* releases do that; I considered it most valuable just to look at the _NN releases. Many patches have been separated out and/or applied from the p5p archives nonetheless.]
| * Tests depend on localeJan D1997-06-112-0/+5
| | | | | | | | | | | | | | | | | | This is (sort of) documented in INSTALL. But you are right, the tests should force the LC_ALL to be 'C'. Note: LANG is not enough, and neither is POSIX as readily available as C. Here are the patches: p5p-msgid: 199705191230.PAA21070@alpha.hut.fi Signed-off-by: Jarkko Hietaniemi <jhi@iki.fi>
| * win32: Configure cf_emailGurusamy Sarathy1997-06-113-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Subject: [PATCH] win32: cf_email (was Re: Win32 embedding w/ 5.004) On Fri, 30 May 1997 11:01:57 +0800, "Gary Ng (Systek)" wrote: >Nick and Sarathy contribute much more that me. BTW, anyone >notice that perl -V on win32 still show 'garyng' no matter who build it >:-) >Can that be removed ? Actually perl -V doesn't show that for me, but perlbug does. Here's a patch. p5p-msgid: 199705301335.JAA05079@aatma.engin.umich.edu
| * win32: user defined shellGurusamy Sarathy1997-06-112-10/+22
| | | | | | | | | | | | | | | | | | This patch replaces the patch in win32.3 in the gnat collection. The reasons for reworking that patch should be evident from reading the patch below. p5p-msgid: 199705291339.JAA21682@aatma.engin.umich.edu
| * lib/io_udp.t fails on VMSJonathan Hudson1997-06-111-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | perl 5.004 built without error or warning on VMS AXP/DECC with DECCRTL (UCX) sockets (no sockshr library). However it fails the lib/io_udp.t test for the following reasons: 1. The 'fromlen' parameter in pp_sysread *must* be sizeof(struct sockaddr) or the DECCRTL fails with an invalid buffer size error. 2. The DECCRTL/UCX getpeerhost() function returns defined and a blank 'sockaddr' for udp hosts. A similar fix to that in vms/sockadapt.h (for sockshr) is required for DECCRTL in pp_sys.c The following diff (unix, sorry VMS folks) patches pp_sys.c so that the udp test is successful using UCX. p5p-msgid: XFMail.970522181042.Jonathan.Hudson@jrhudson.demon.co.uk
| * win32: additional default librariesGurusamy Sarathy1997-06-110-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found the default libs list is still incomplete (incomplete enough for Tk to fail to build). This patch adds the additional default libraries to MM_Win32.pm. Note LDLOADLIBS can be overridden from Makefile.PL (although Tk/win32 seems to want to set it directly in its Makefile, rather than via an attribute list, and the direct setting gets overridden by the default because the default comes later in the makefile). The patch is against the jumbo patch that nobody seems to like. It is *my* new baseline, sorry. - Sarathy. gsar@engin.umich.edu p5p-msgid: 199705291332.JAA21560@aatma.engin.umich.edu
| * Compiling perl5.004 on NEWS-OS 4.xMakoto MATSUSHITA (=?ISO-2022-JP?B?GyRCJF4kRCQ3JD8kXiQzJEgbKEI=?=)1997-06-112-3/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | Here (attached below) is a patch for compiling perl5 on NEWS-OS 4.x. It contains a new hints file for NEWS-OS 4.x and some modification to Configure. I've tested on perl5.003, perl5.003_99 and perl5.004. Background: Current release of NEWS-OS is version 6.1.x and it is SystemV variant. However, NEWS-OS 4.x is 4.3BSD-variant and commonly used in Japan. So, I named 'newsos' for newer release, and 'newsos4' for older release. Unfortunately, NEWS-OS 4.x has no uname(1). p5p-msgid: 19970521132814F.matusita@ics.es.osaka-u.ac.jp
| * INSTALL-1.18Andy Dougherty1997-06-111-9/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes two problems in the INSTALL file in 5.004. This fix is appropriate for 5.004_01. First, the INSTALL file erroneously claims you can set all the install* variables from the Configure command line. You can't. That's awaiting my -Dinstallprefix patch, which is so far down on the ToDo list that it may never get done. Second, I misspelled 'override'. I had two 'v's and one 'r'. :-) p5p-msgid: Pine.SOL.3.95q.970529142739.662D-100000@fractal.lafayette.edu
| * 5.004 POD stuffDarren/Torin/Who Ever1997-06-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Caught a small typo in perldiag.pod; patch below. p5p-msgid: 9705191839.AA28702@lemming.engeast Signed-off-by: "Paul D. Smith" <psmith@BayNetworks.COM> Signed-off-by: Gurusamy Sarathy <gsar@engin.umich.edu> Signed-off-by: Jarkko Hietaniemi <jhi@iki.fi> Signed-off-by: Michael R Cook <mcook@cognex.com> Signed-off-by: Jim Avera <avera@hal.com> Signed-off-by: Larry W. Virden <lvirden@cas.org>