| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
For: https://rt.cpan.org/Ticket/Display.html?id=114105
|
|
|
|
|
|
|
|
|
|
| |
The way CI works it is easy to merge a patch that will lead to
a cmp_version test fail. If two people modify the same file, bump
it to the same new version, then there will be no conflict nor test
fail, until it is merged at which point it will fail because the
code has changed but the version hasn't.
This is a quickie fixup when I got hit by this today with threads.
|
|
|
|
| |
Without the apostrophes these look like plurals
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
store_code() does a POPs, but not a PUTBACK, before returning, so
PL_stack_sp was one too high on return. For example in the following
code:
use Storable qw(freeze);
my $obj = [
sub { 1; },
sub { 2; },
sub { 4; },
sub { 4; },
];
$Storable::Deparse = 1;
while (1) {
my $freezed = freeze $obj;
}
On the first four calls to store_code() - to deparse each of the anon
subs - PL_stack_sp is one higher than the previous call.
On subsequent calls to freeze(), PL_stack_sp is reset to its original
value.
I don't know whether this bug has any visible effects; I spotted it during
my work to make the stack reference-counted; PL_stack_sp not being
decremented caused the SV at that location to be double-counted.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Compute the great circle distance with a formula that has better
numerical properties. The formula used now is accurate for all
distances.
- Add a few tests to verify.
- This fixes CPAN RT #78938
Improve documentation for great_circle_distance()
For: https://github.com/Perl/perl5/pull/20212
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dual-life distribution Math-Complex is now maintained by Perl 5 Porters
in blead and subsequently released to CPAN. The two modules in this
distribution, Math::Complex and Math::Trig, previously incremented their
version numbers independently of each other. However, in blead we
generally try to keep all .pm files at the same $VERSION. So let's
standardize these modules at one number and keep them in sync going
forward.
Once we've done this, we can manually resolve the version conflicts in
https://github.com/Perl/perl5/pull/20212 and merge that p.r. into blead.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Improve the documentation for great_circle_waypoint() to include that
$way is not limited to [0..1]. Also explain more precisely what is
returned.
This closes CPAN RT #136646.
Committer: correct one typo
For: https://github.com/Perl/perl5/pull/20200
|
|
|
|
|
|
|
|
|
|
|
| |
- Correct typo where "pi" should be "phi".
- Spherical coordinates should use the same order of the coordinates
everywhere, i.e., rho, theta, phi.
Committer: lib/Math/Trig.pm: Increment $VERSION
For: https://github.com/Perl/perl5/pull/20210
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code as written would have had no effect since the value in
$^O is 'VMS' not 'vms' so it's better to remove the confused and
confusing code.
_backtick_pwd is not normally called on VMS because it has its own
set of routines dispatched via the %METHOD_MAP hash.
In the unlikely event that _backtick_pwd got called on VMS, it
would either fail because there is no pwd command, or, if running
under some Unix emulation environment, work just like Unix, and
therefore need no special handling of $ENV{PATH} that is different
from Unix.
|
| |
|
|
|
|
|
| |
In #19645 I added a fix for empty paths under taint mode. This fix may have
changed VMS behavior, which this patch should fix.
|
| |
|
|
|
|
|
|
|
|
|
| |
We always had a bug with the value 0, when fixing it, we discovered a lot
of people were doing duplicate aliases with 0. This patch disables the warnings
except when in a special author mode, as it makes no sense to show these warnings
to end users. It would seem most times creating such aliases is not an issue and
is entirely deliberate. So showing such warnings only to module authors and only
on request also makes sense.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this case we're testing that the result is always true, and it
happens the compiler realizes that the return value is always true,
even in isolation.
Returning the variable that we've already set to point to
PL_bufptr eliminates the warning.
The compiler is still smart enough to eliminate the comparison
on optimized builds. Some linter may still complain about it.
|
|
|
|
|
|
| |
Some of these tests (which involve moving blocks of data around in a
file) are occasionally randomly timing out on some slow smokers.
Double the timeout from 5s to 10s and see if the problem goes away.
|
| |
|
|
|
|
| |
The version in the pod has been long wrong. We are on 3.48 now, it was 3.13_01.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use warn instead of print STDERR, and provide a way to make
errors trigger a die instead of an exit(1).
Currently the module code is written as though the only way
it will be used is via the xsubpp script, so the library does
annoying things like calling exit() instead of die() to signal
an exception. It also uses print STDERR instead of warn,
which means the test code can't just use a $SIG{__WARN__} hook
to see its warnings, and instead has to include PrimitiveCapture
in the t directory. These two things combine annoyingly in our
test code such that when you break the module you can see tests
exiting early, but with no useful diagnostics as to why.
This patch reworks this to use "warn" instead of print STDERR,
and to provide a way to enable the use of "die" instead of exit.
Thus making debugging failing tests far easier.
|
|
|
|
| |
The upcoming C++23 and C23 standards add #elifdef, #elifndef.
|
|
|
|
|
|
|
| |
Also normalize warnings. It used to be if you created an alias
of the root function (0) no warning would be produced. Now
we will produce a warning, but we also allow symbolic references
to defuse the warning.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes you *want* to create multiple names for the same
functionality, but doing so with the ALIAS functionality requires
awkward workarounds. This adds a new "symbolic alias" that does
not warn on dupes as creating a dupe is its whole point. For a
symbolic alias the value is the name of an existing alias.
This also cleans up some of the warnings related to aliases so
we distinguish between when a duplicate is truly ignored or
where it overrides a previous value. And deal with a few other
edge cases properly.
|
|
|
|
|
|
|
|
|
|
| |
This patch makes it possible to omit some of the whitespace around
preprocessor directives. It teaches fetch_para() to understand
that a #else or #endif directive that does not end a #if that
was seen in the current "paragraph" should not be parsed as part
of that paragraph. This means that a conditional block that defines
the same sub under different define conditions need not have extra
whitespace after each sub definition.
|
|
|
|
| |
Make sure our output is deterministic.
|
|
|
|
|
|
|
|
|
|
| |
Currently some tests have a 5 second timeout. If this is exceeded,
the test number is output as "not ok", along with "# Timeout" to
STDOUT. Change the latter to output to STDERR along with the test
filename and test number, for easer debugging of smoke logs.
(Really these test files need upgrading to use Test::* but that's a job
for another day and another person....)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 7169efc77525df70484a824bff4ceebd1fafc760, perl's core STMT_START
and STMT_END macros no longer try to use brace groups, due to the
warnings they can generate and their very limited usefulness.
That commit also changed Devel::PPPort to remove the use of brace groups
in STMT_START/STMT_END. That led to errors in older perls, so it was
partly reverted in e08ee3cb66f362c4901846a46014cfdfcd60326c. Since then,
various other macros have been improved to properly work with brace
groups enabled or disabled.
We can now remove the brace group using variant of STMT_START/STMT_END,
which will silence the warnings from clang.
|
|
|
|
|
|
|
|
|
|
| |
The macro for croak_sv when brace groups are not enabled uses
STMT_START/STMT_END. This works when used as a statement, but would
break if used as part of an expression.
To resolve this, change that macro to use a function. As a static inline
function with a namespaced name, it shouldn't cause problems with
namespace pollution.
|
|
|
|
|
|
|
| |
The original regex was off and showed this test as passing when
it was actually failing, which is what we expect and why the test
is marked as TODO. The test accidentally doubled the extension
expected in the filename, and this patch corrects that mistake.
|
| |
|
|
|
|
|
| |
Previously this would complain it didn't know the object type
when preparing to call STORABLE_freeze.
|
|
|
|
|
|
|
|
|
|
|
| |
This produced an opaque message when it was asked to freeze an
object of an unsupported type. Changes:
- replace the opaque internal object type number with the typical perl name of the
type ("GLOB" instead of "8")
- include the class of the object being frozen to identify which class needs work
- include name of the function we're trying to call to do the freeze,
if possible
|
|
|
|
|
|
|
|
|
|
|
| |
In the first sample .xs file supplied for this branch, a function named
'dbh' was declared twice, once inside an 'ifdef', once outside. This
led me to think that that dual use of the string 'dbh' was the problem
EUPXS was stumbling upon.
However, that appears to be incorrect. If we supply a second sample .xs
file in which we use two different function names, we still get the
undesired warning.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Add `my` to synopsis.
Committer: Data-Dumper: Update $VERSION in POD. The release date no
longer appears in the POD, so let's remove the comment admonishing us to
update it.
For: https://github.com/Perl/perl5/pull/20224
|
|
|
|
| |
A variable was declared twice; remove the redundant one
|
| |
|
|
|
|
| |
Older perls don't define these variables.
|
| |
|
| |
|
|
|
|
|
|
|
| |
This makes the logic a bit simpler, and makes it easier to debug
as well. Reducing the amount of code that needs to be inside
the eval makes it easier to debug what is going on, especially
from an internals point of view (eg with -Dl enabled).
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In 4ab96809c99e944e70c21779641e4b1c9a00df41 the perl version
data was bumped, without doing any Module-CoreList changes and
now related tests are failing. Release managers guide said to
do:
./perl -Ilib Porting/corelist.pl cpan
to update the corelist data, which is this commit. Not sure if
this is 100% the right thing to do, but it makes the test fails
stop for now. Someone who knows this better can do any mop-up.
|
|\
| |
| |
| | |
they found
|
| | |
|
| |
| |
| |
| | |
and update Changes
|