From 7201856e3a53d05224c96b82b7b61a85d7cce1a6 Mon Sep 17 00:00:00 2001
From: Bram <perl-rt@wizbit.be>
Date: Sun, 11 Sep 2022 22:18:31 +0200
Subject: testsuite.yml: Remove fetching of tags

The only test that need the git tags (afaik) is porting/cmp_version.t;
But the fetching of tags isn't really working for that test.

Basically the repo is cloned with:
	$ git clone --depth 1 https://github.com/perl/perl5
	$ git fetch --depth=1 origin +refs/tags/*:refs/tags/*

And then later the test uses:
	$ git describe --abbrev=0 HEAD

and it expects to find a tag.

However doing that:
	$ git describe --abbrev=0 HEAD
	fatal: No tags can describe '6a011f13d7690dbe2e03ad7500756c983bcb1834'.

So it's not really working..

This can also be seen in the CI logs[^1], the output contains:
	porting/cmp_version.t ..... skipped: Git found, but no Git tags found

There are only 3 CI configs that do run the porting/cmp_version.t test:
	- 'Sanity: Linux -Dusethreads' - this is intended
	- 'linux i386/ubuntu (-Dusedevel)'[^2]
	- 'cygwin'[^3]

[^1]: CI logs of: 'linux (-Uusethreads)', 'linux (-Duseshrplib ...)',
      'linux (-Duserelocatableinc)', 'linux (-Dcc='clang')', 'linux (-Dcc='g++')',
      'install', 'macOS (catalina) xcode 12 (-Uusethreads)',
      'macOS (catalina) xcode 12 (-Duseithreads -Duseshrplib)', 'Windows msvc142',
      'Windows mingw64', 'ASAN (-Accflags=-DPURIFY)', 'ASAN (-DDEBUGGING)',
      'ASAN (-Dusethreads)', 'PERL_UNICODE (-Uusethreads)',
      'PERL_UNICODE (-Dusethreads ...')

[^2]: it uses 'actions/checkout@v1' to do the checkout which does a full clone
[^3]: it manually runs `git clone`, doing a full clone (with all history)
---
 .github/workflows/testsuite.yml | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

(limited to '.github/workflows')

diff --git a/.github/workflows/testsuite.yml b/.github/workflows/testsuite.yml
index 3e0970019e..24962a53e0 100644
--- a/.github/workflows/testsuite.yml
+++ b/.github/workflows/testsuite.yml
@@ -164,10 +164,9 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgdbm-dev libdb-dev
       - uses: actions/checkout@v2
-      - name: git cfg + fetch tags
+      - name: git cfg
         run: |
           git config diff.renameLimit 999999
-          git fetch --depth=1 origin +refs/tags/*:refs/tags/*
       - name: Configure
         run: |
           ./Configure -des -Dusedevel ${{ matrix.CONFIGURE_ARGS }} -Dprefix="$HOME/perl-blead" -DDEBUGGING
@@ -261,10 +260,9 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgdbm-dev libdb-dev
       - uses: actions/checkout@v2
-      - name: git cfg + fetch tags
+      - name: git cfg
         run: |
           git config diff.renameLimit 999999
-          git fetch --depth=1 origin +refs/tags/*:refs/tags/*
       - name: Configure
         run: |
           ./Configure -des -Dusedevel -Duseshrplib -Dusesitecustomize -Duselongdouble -Dprefix="$HOME/perl-blead" -DDEBUGGING
@@ -523,10 +521,9 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgdbm-dev libdb-dev
       - uses: actions/checkout@v2
-      - name: git cfg + fetch tags
+      - name: git cfg
         run: |
           git config diff.renameLimit 999999
-          git fetch --depth=1 origin +refs/tags/*:refs/tags/*
       - name: manicheck
         run: |
           perl Porting/manicheck --exitstatus
@@ -575,10 +572,9 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgdbm-dev libdb-dev
       - uses: actions/checkout@v2
-      - name: git cfg + fetch tags
+      - name: git cfg
         run: |
           git config diff.renameLimit 999999
-          git fetch --depth=1 origin +refs/tags/*:refs/tags/*
       - name: Configure
         run: |
           ./Configure -des -Dusedevel -Dcc="clang -fsanitize=address" -Dld="clang -fsanitize=address" ${{ matrix.CONFIGURE_ARGS }} -Dprefix="$HOME/perl-blead"
@@ -624,10 +620,9 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libgdbm-dev libdb-dev
       - uses: actions/checkout@v2
-      - name: git cfg + fetch tags
+      - name: git cfg
         run: |
           git config diff.renameLimit 999999
-          git fetch --depth=1 origin +refs/tags/*:refs/tags/*
       - name: Show Locales
         run: locale -a
       - name: Configure
-- 
cgit v1.2.1