From b8413ac3c2aeba8d9cbe9ce77d7eafc3f5ae0fef Mon Sep 17 00:00:00 2001 From: Father Chrysostomos Date: Fri, 20 Jan 2012 12:59:35 -0800 Subject: pp_sys.c:pp_stat: Change scope of havefp var This is only used in the if(gv != PL_defgv) block now. Also, it was being used uninitialized for bad iorefs, probably resulting in random warning suppression (untested). --- pp_sys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pp_sys.c b/pp_sys.c index 246c9ad4c0..b201827b86 100644 --- a/pp_sys.c +++ b/pp_sys.c @@ -2759,7 +2759,6 @@ PP(pp_stat) if (PL_op->op_flags & OPf_REF ? (gv = cGVOP_gv, 1) : !!(sv=POPs, gv = MAYBE_DEREF_GV(sv))) { - bool havefp; if (PL_op->op_type == OP_LSTAT) { if (gv != PL_defgv) { do_fstat_warning_check: @@ -2774,9 +2773,10 @@ PP(pp_stat) Perl_croak(aTHX_ "The stat preceding lstat() wasn't an lstat"); } - havefp = FALSE; if (gv != PL_defgv) { + bool havefp; do_fstat_have_io: + havefp = FALSE; PL_laststype = OP_STAT; PL_statgv = gv ? gv : (GV *)io; sv_setpvs(PL_statname, ""); -- cgit v1.2.1