From c97f73fe8db20adb57725eac1957667c9036399b Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Tue, 16 Mar 2021 21:46:19 +0000
Subject: Create internal sub parse_input_for_podtree()

This clears up a bit of semantic confusion.  We were using one lexically
scoped variable -- my $parser -- to hold two different objects: one for
parsing input, one for writing output.  We can encapsulate the working
of the input parser to make the code more readable.

Signed-off-by: James E Keenan <jkeenan@cpan.org>
---
 ext/Pod-Html/lib/Pod/Html.pm | 33 ++++++++++++++++++++-------------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/ext/Pod-Html/lib/Pod/Html.pm b/ext/Pod-Html/lib/Pod/Html.pm
index d2b2d8c051..118812bf76 100644
--- a/ext/Pod-Html/lib/Pod/Html.pm
+++ b/ext/Pod-Html/lib/Pod/Html.pm
@@ -343,17 +343,7 @@ sub pod2html {
         $input = *ARGV;
     }
 
-    # set options for input parser
-    my $parser = Pod::Simple::SimpleTree->new;
-    # Normalize whitespace indenting
-    $parser->strip_verbatim_indent(\&trim_leading_whitespace);
-
-    $parser->codes_in_verbatim(0);
-    $parser->accept_targets(qw(html HTML));
-    $parser->no_errata_section(!$globals->{Poderrors}); # note the inverse
-
-    warn "Converting input file $globals->{Podfile}\n" if $globals->{Verbose};
-    my $podtree = $parser->parse_file($input)->root;
+    my $podtree = parse_input_for_podtree($globals, $input);
 
     unless(defined $globals->{Title}) {
         if($podtree->[0] eq "Document" && ref($podtree->[2]) eq "ARRAY" &&
@@ -374,7 +364,8 @@ sub pod2html {
     $globals->{Title} = html_escape($globals->{Title});
 
     # set options for the HTML generator
-    $parser = Pod::Simple::XHTML::LocalPodLinks->new();
+    my $parser = Pod::Simple::XHTML::LocalPodLinks->new();
+    my $output;
     $parser->codes_in_verbatim(0);
     $parser->anchor_items(1); # the old Pod::Html always did
     $parser->backlink($globals->{Backlink}); # linkify =head1 directives
@@ -383,7 +374,7 @@ sub pod2html {
     $parser->htmlfileurl($globals->{Htmlfileurl});
     $parser->htmlroot($globals->{Htmlroot});
     $parser->index($globals->{Doindex});
-    $parser->output_string(\my $output); # written to file later
+    $parser->output_string(\$output); # written to file later
     $parser->pages(\%Pages);
     $parser->quiet($globals->{Quiet});
     $parser->verbose($globals->{Verbose});
@@ -439,6 +430,22 @@ HTMLFOOT
     write_file($globals, $output);
 }
 
+sub parse_input_for_podtree {
+    my ($globals, $input) = @_;
+    # set options for input parser
+    my $input_parser = Pod::Simple::SimpleTree->new;
+    # Normalize whitespace indenting
+    $input_parser->strip_verbatim_indent(\&trim_leading_whitespace);
+
+    $input_parser->codes_in_verbatim(0);
+    $input_parser->accept_targets(qw(html HTML));
+    $input_parser->no_errata_section(!$globals->{Poderrors}); # note the inverse
+
+    warn "Converting input file $globals->{Podfile}\n" if $globals->{Verbose};
+    my $podtree = $input_parser->parse_file($input)->root;
+    return $podtree;
+}
+
 sub get_cache {
     my $globals = shift;
 
-- 
cgit v1.2.1