From eb0a891037ac1524471442b4bb0490d717b04496 Mon Sep 17 00:00:00 2001 From: "Craig A. Berry" Date: Sat, 8 Apr 2023 10:15:55 -0500 Subject: .PHONY not portable in dist/Locale-Maketext/Makefile.PL It breaks the build on VMS because .PHONY is a syntax error in the native make-like utilities. It probably also breaks nmake builds on Windows. The solution here is to exclude the .PHONY directive unless running under gmake or bsdmake. --- dist/Locale-Maketext/Makefile.PL | 11 +++++++++-- dist/Locale-Maketext/lib/Locale/Maketext.pm | 2 +- 2 files changed, 10 insertions(+), 3 deletions(-) (limited to 'dist') diff --git a/dist/Locale-Maketext/Makefile.PL b/dist/Locale-Maketext/Makefile.PL index 72cc31e6da..212982d9ba 100644 --- a/dist/Locale-Maketext/Makefile.PL +++ b/dist/Locale-Maketext/Makefile.PL @@ -28,8 +28,15 @@ WriteMakefile( ); sub MY::postamble { - return <<'MAKE_FRAG'; -.PHONY: tags critic + # .PHONY is not portable + my $self = shift; + my $phony_line = $self->can('is_make_type') + && ($self->is_make_type('gmake') + || $self->is_make_type('bsdmake')) + ? '.PHONY: tags critic' + : ''; + + return "$phony_line\n\n" . <<'MAKE_FRAG'; tags: ctags -f tags --recurse --totals \ diff --git a/dist/Locale-Maketext/lib/Locale/Maketext.pm b/dist/Locale-Maketext/lib/Locale/Maketext.pm index 972f929985..8979c202f0 100644 --- a/dist/Locale-Maketext/lib/Locale/Maketext.pm +++ b/dist/Locale-Maketext/lib/Locale/Maketext.pm @@ -25,7 +25,7 @@ BEGIN { } -our $VERSION = '1.32'; +our $VERSION = '1.33'; our @ISA = (); our $MATCH_SUPERS = 1; -- cgit v1.2.1