From f8db7d5b698ee09de200fdee909d6f4ea719ffac Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Sun, 5 Aug 2018 06:41:05 -0600 Subject: Use sv_catpvs where appropriate vs sv_catpv This moves calculations definitely to compile time; some optimizing compilers may already do this, but some may not. --- doio.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'doio.c') diff --git a/doio.c b/doio.c index 16daf9fd11..cc15bf9f41 100644 --- a/doio.c +++ b/doio.c @@ -3244,24 +3244,24 @@ Perl_vms_start_glob # if defined(OS2) sv_setpv(tmpcmd, "for a in "); sv_catsv(tmpcmd, tmpglob); - sv_catpv(tmpcmd, "; do echo \"$a\\0\\c\"; done |"); + sv_catpvs(tmpcmd, "; do echo \"$a\\0\\c\"; done |"); # elif defined(DJGPP) sv_setpv(tmpcmd, "/dev/dosglob/"); /* File System Extension */ sv_catsv(tmpcmd, tmpglob); # else sv_setpv(tmpcmd, "perlglob "); sv_catsv(tmpcmd, tmpglob); - sv_catpv(tmpcmd, " |"); + sv_catpvs(tmpcmd, " |"); # endif # elif defined(CSH) sv_setpvn(tmpcmd, PL_cshname, PL_cshlen); - sv_catpv(tmpcmd, " -cf 'set nonomatch; glob "); + sv_catpvs(tmpcmd, " -cf 'set nonomatch; glob "); sv_catsv(tmpcmd, tmpglob); - sv_catpv(tmpcmd, "' 2>/dev/null |"); + sv_catpvs(tmpcmd, "' 2>/dev/null |"); # else sv_setpv(tmpcmd, "echo "); sv_catsv(tmpcmd, tmpglob); - sv_catpv(tmpcmd, "|tr -s ' \t\f\r' '\\n\\n\\n\\n'|"); + sv_catpvs(tmpcmd, "|tr -s ' \t\f\r' '\\n\\n\\n\\n'|"); # endif /* !DOSISH && !CSH */ { SV ** const svp = hv_fetchs(GvHVn(PL_envgv), "LS_COLORS", 0); -- cgit v1.2.1