From 75feedba47600d94d18d49dbcbdf46393b6c6cc5 Mon Sep 17 00:00:00 2001 From: Jarkko Hietaniemi Date: Wed, 23 Jul 2014 10:38:50 -0400 Subject: Use UV instead of Size_t. A strong reason for using UV are the promised custom codepoints, they go beyond 32-bit. The overflow logic didn't work if Size_t was 32-bit but the UV was 64-bit. Steal the battle-proven logic from grok_number_flags(). The numeric.xs or grok.t were not right in 32-bit, either. Add comments. --- embed.fnc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'embed.fnc') diff --git a/embed.fnc b/embed.fnc index d02e555feb..90c56ed5ad 100644 --- a/embed.fnc +++ b/embed.fnc @@ -807,7 +807,7 @@ Apd |int |grok_number |NN const char *pv|STRLEN len|NULLOK UV *valuep Apd |int |grok_number_flags|NN const char *pv|STRLEN len|NULLOK UV *valuep|U32 flags ApdR |bool |grok_numeric_radix|NN const char **sp|NN const char *send Apd |UV |grok_oct |NN const char* start|NN STRLEN* len_p|NN I32* flags|NULLOK NV *result -Apdn |Size_t |grok_atou |NN const char* pv|NULLOK const char** endptr +Apdn |UV |grok_atou |NN const char* pv|NULLOK const char** endptr : These are all indirectly referenced by globals.c. This is somewhat annoying. p |int |magic_clearenv |NN SV* sv|NN MAGIC* mg p |int |magic_clear_all_env|NN SV* sv|NN MAGIC* mg -- cgit v1.2.1