From cb077ed29694c30e42772d2c1fc2d9a9b3183eca Mon Sep 17 00:00:00 2001 From: Daniel Dragan Date: Mon, 12 Nov 2012 00:04:00 -0500 Subject: rmv context from Perl_croak_no_modify and Perl_croak_xs_usage Remove the context/pTHX from Perl_croak_no_modify and Perl_croak_xs_usage. For croak_no_modify, it now has no parameters (and always has been no return), and on some compilers will now be optimized to a conditional jump. For Perl_croak_xs_usage one push asm opcode is removed at the caller. For both funcs, their footprint in their callers (which probably are hot code) is smaller, which means a tiny bit more room in the cache. My text section went from 0xC1A2F to 0xC198F after apply this. Also see http://www.nntp.perl.org/group/perl.perl5.porters/2012/11/msg195233.html . --- ext/Tie-Hash-NamedCapture/NamedCapture.pm | 2 +- ext/Tie-Hash-NamedCapture/NamedCapture.xs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'ext') diff --git a/ext/Tie-Hash-NamedCapture/NamedCapture.pm b/ext/Tie-Hash-NamedCapture/NamedCapture.pm index 932e4404d1..9702666799 100644 --- a/ext/Tie-Hash-NamedCapture/NamedCapture.pm +++ b/ext/Tie-Hash-NamedCapture/NamedCapture.pm @@ -1,7 +1,7 @@ use strict; package Tie::Hash::NamedCapture; -our $VERSION = "0.08"; +our $VERSION = "0.09"; require XSLoader; XSLoader::load(); # This returns true, which makes require happy. diff --git a/ext/Tie-Hash-NamedCapture/NamedCapture.xs b/ext/Tie-Hash-NamedCapture/NamedCapture.xs index 58b7da7e0d..04cc4638e6 100644 --- a/ext/Tie-Hash-NamedCapture/NamedCapture.xs +++ b/ext/Tie-Hash-NamedCapture/NamedCapture.xs @@ -84,7 +84,7 @@ FETCH(...) if (!rx || !SvROK(ST(0))) { if (ix & UNDEF_FATAL) - Perl_croak_no_modify(aTHX); + Perl_croak_no_modify(); else XSRETURN_UNDEF; } -- cgit v1.2.1