From cb777d7125776d73756033f32e5e2040a8826cc1 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Sat, 17 Dec 2022 08:34:33 -0700 Subject: Fix broken API: sync_locale() This fixes GH #20565. Lack of tests allowed sync_locale() to get broken until CPAN testing showed it so. Basically, I blew it in 9f5a615be674d7663d3b4719849baa1ba3027f5b. Most egregiously, I forgot to turn back on when a sync_locale() is executed, the toggling for locales whose radix character isn't a dot. And this needs a way to tell the other code that it needs to recompute things at this time, since our records don't reflect what happened before the sync. --- ext/XS-APItest/t/locale.t | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'ext') diff --git a/ext/XS-APItest/t/locale.t b/ext/XS-APItest/t/locale.t index 19efa9546b..1a14fb45cf 100644 --- a/ext/XS-APItest/t/locale.t +++ b/ext/XS-APItest/t/locale.t @@ -62,12 +62,8 @@ SKIP: { "comma recognized in global comma locale for SvNV"); isnt(sync_locale, 0, "sync_locale() returns that was in the global locale"); - TODO: { - local $TODO = "GH #20565"; - - is(check_in_bounds(newSvNV("4.888"), 4.88, 4.89), 1, - "dot recognized in perl-controlled comma locale for SvNV"); - } + is(check_in_bounds(newSvNV("4.888"), 4.88, 4.89), 1, + "dot recognized in perl-controlled comma locale for SvNV"); } my %correct_C_responses = ( -- cgit v1.2.1