From f185f65418467d10121bac955af6bca4776490e3 Mon Sep 17 00:00:00 2001 From: Karl Williamson Date: Thu, 3 Sep 2015 21:06:16 -0600 Subject: Start fixing some pod pedantic errors This fixes a bunch of them, but there are many more --- os2/OS2/OS2-ExtAttr/ExtAttr.pm | 4 +- os2/OS2/OS2-Process/Process.pm | 84 +++++++++++++++++++++++------------------- os2/OS2/OS2-REXX/DLL/DLL.pm | 15 ++++---- os2/OS2/OS2-REXX/REXX.pm | 51 ++++++++++++------------- 4 files changed, 82 insertions(+), 72 deletions(-) (limited to 'os2') diff --git a/os2/OS2/OS2-ExtAttr/ExtAttr.pm b/os2/OS2/OS2-ExtAttr/ExtAttr.pm index a48a6624bd..06c80c3aa3 100644 --- a/os2/OS2/OS2-ExtAttr/ExtAttr.pm +++ b/os2/OS2/OS2-ExtAttr/ExtAttr.pm @@ -3,7 +3,7 @@ package OS2::ExtAttr; use strict; use XSLoader; -our $VERSION = '0.03'; +our $VERSION = '0.04'; XSLoader::load 'OS2::ExtAttr', $VERSION; # Preloaded methods go here. @@ -162,7 +162,7 @@ Three convenience functions are provided: The default value for C is 0. In addition, all the C<_ea_*> and C<_ead_*> functions defined in EMX -library are supported, with leading C<_ea/_ead> stripped. +library are supported, with leading C<_ea> and C<_ead> stripped. =head1 AUTHOR diff --git a/os2/OS2/OS2-Process/Process.pm b/os2/OS2/OS2-Process/Process.pm index babe470198..08b619f8e3 100644 --- a/os2/OS2/OS2-Process/Process.pm +++ b/os2/OS2/OS2-Process/Process.pm @@ -20,7 +20,7 @@ BEGIN { #require AutoLoader; our @ISA = qw(Exporter); - our $VERSION = "1.10"; + our $VERSION = "1.11"; XSLoader::load('OS2::Process', $VERSION); } @@ -1410,7 +1410,8 @@ message id $msg, they default to 0. E.g., SC_MAXIMIZE SC_RESTORE); $hwnd = process_hentry()->{owner_hwnd}; # Emulate choosing `Restore' from the window menu: - PostMsg $hwnd, WM_SYSCOMMAND, MPFROMSHORT(SC_RESTORE); # Not immediate + PostMsg $hwnd, WM_SYSCOMMAND, MPFROMSHORT(SC_RESTORE); # Not + # immediate # Emulate `Show-Contextmenu' (Double-Click-2), two ways: PostMsg ActiveWindow, WM_CONTEXTMENU; @@ -1874,8 +1875,10 @@ a combination of MB_YESNOCANCEL YES, NO, and CANCEL Color or Icon - MB_ICONHAND a small red circle with a red line across it. - MB_ERROR a small red circle with a red line across it. + MB_ICONHAND a small red circle with a red line across + it. + MB_ERROR a small red circle with a red line across + it. MB_ICONASTERISK an information (i) icon. MB_INFORMATION an information (i) icon. MB_ICONEXCLAMATION an exclamation point (!) icon. @@ -1885,12 +1888,16 @@ a combination of MB_NOICON No icon. Default action (i.e., focussed button; default is MB_DEFBUTTON1) - MB_DEFBUTTON1 The first button is the default selection. - MB_DEFBUTTON2 The second button is the default selection. - MB_DEFBUTTON3 The third button is the default selection. + MB_DEFBUTTON1 The first button is the default + selection. + MB_DEFBUTTON2 The second button is the default + selection. + MB_DEFBUTTON3 The third button is the default + selection. Modality indicator - MB_APPLMODAL Message box is application modal (default). + MB_APPLMODAL Message box is application modal + (default). MB_SYSTEMMODAL Message box is system modal. Mobility indicator @@ -1912,9 +1919,9 @@ specify the owner as the parent if this option is used. Additionally, the following flag is possible, but probably not very useful: Help button - MB_HELP a HELP button appears, which sends a WM_HELP - message is sent to the window procedure of the - message box. + MB_HELP a HELP button appears, which sends a WM_HELP + message is sent to the window procedure of + the message box. Other optional arguments: $parent window, $owner_window, $helpID (used with C message if C style is given). @@ -1930,7 +1937,7 @@ The return value is one of MBID_YES YES was selected MBID_NO NO was selected - 0 Function not successful; an error occurred. + 0 Function not successful; an error occurred. B keyboard transversal by pressing C key does not work. Do not appear in window list, so may be hard to find if covered by other @@ -2164,10 +2171,10 @@ Implement SOMETHINGFROMMR. > >No matter what message I send it, it's being ignored. - You need to get the style of the buttons using WinQueryWindowULong/QWL_STYLE, - set and reset the BS_DEFAULT bits as appropriate and then use - WinSetWindowULong/QWL_STYLE to set the button style. - Something like this: + You need to get the style of the buttons using + WinQueryWindowULong/QWL_STYLE, set and reset the BS_DEFAULT bits as + appropriate and then use WinSetWindowULong/QWL_STYLE to set the + button style. Something like this: hwnd1 = WinWindowFromID (hwnd, id1); hwnd2 = WinWindowFromID (hwnd, id2); style1 = WinQueryWindowULong (hwnd1, QWL_STYLE); @@ -2177,11 +2184,12 @@ Implement SOMETHINGFROMMR. WinSetWindowULong (hwnd1, QWL_STYLE, style1); WinSetWindowULong (hwnd2, QWL_STYLE, style2); - > How to do query and change a frame creation flags for existing window? + > How to do query and change a frame creation flags for existing + > window? Set the style bits that correspond to the FCF_* flag for the frame - window and then send a WM_UPDATEFRAME message with the appropriate FCF_* - flag in mp1. + window and then send a WM_UPDATEFRAME message with the appropriate + FCF_* flag in mp1. ULONG ulFrameStyle; ulFrameStyle = WinQueryWindowULong( WinQueryWindow(hwnd, QW_PARENT), @@ -2195,25 +2203,25 @@ Implement SOMETHINGFROMMR. MPFROMP(FCF_SIZEBORDER), MPVOID ); - If the FCF_* flags you want to change does not have a corresponding FS_* - style (i.e. the FCF_* flag corresponds to the presence/lack of a frame - control rather than a property of the frame itself) then you create or - destroy the appropriate control window using the correct FID_* window - identifier and then send the WM_UPDATEFRAME message with the appropriate - FCF_* flag in mp1. - - /* - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -* - | SetFrameBorder() | - | Changes a frame window's border to the requested type. | - | | - | Parameters on entry: | - | hwndFrame -> Frame window whose border is to be changed. | - | ulBorderStyle -> Type of border to change to. | - | | - | Returns: | - | BOOL -> Success indicator. | - | | - * - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -*/ + If the FCF_* flags you want to change does not have a corresponding + FS_* style (i.e. the FCF_* flag corresponds to the presence/lack of a + frame control rather than a property of the frame itself) then you + create or destroy the appropriate control window using the correct + FID_* window identifier and then send the WM_UPDATEFRAME message with + the appropriate FCF_* flag in mp1. + + /* - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - * + | SetFrameBorder() | + | Changes a frame window's border to the requested type. | + | | + | Parameters on entry: | + | hwndFrame -> Frame window whose border is to be changed. | + | ulBorderStyle -> Type of border to change to. | + | | + | Returns: | + | BOOL -> Success indicator. | + | | + * - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - */ BOOL SetFrameBorder( HWND hwndFrame, ULONG ulBorderType ) { ULONG ulFrameStyle; BOOL fSuccess = TRUE; diff --git a/os2/OS2/OS2-REXX/DLL/DLL.pm b/os2/OS2/OS2-REXX/DLL/DLL.pm index a7d4504d68..7db94884a6 100644 --- a/os2/OS2/OS2-REXX/DLL/DLL.pm +++ b/os2/OS2/OS2-REXX/DLL/DLL.pm @@ -1,6 +1,6 @@ package OS2::DLL; -our $VERSION = '1.05'; +our $VERSION = '1.06'; use Carp; use XSLoader; @@ -144,11 +144,11 @@ See documentation of L module if you need the variable pool. =head1 SYNOPSIS - use OS2::DLL; - $emx_dll = OS2::DLL->module('emx'); - $emx_version = $emx_dll->emx_revision(); - $func_emx_version = $emx_dll->wrapper_REXX('#128'); # emx_revision - $emx_version = $func_emx_version->(); + use OS2::DLL; + $emx_dll = OS2::DLL->module('emx'); + $emx_version = $emx_dll->emx_revision(); + $func_emx_version = $emx_dll->wrapper_REXX('#128'); # emx_revision + $emx_version = $func_emx_version->(); =head1 DESCRIPTION @@ -266,7 +266,8 @@ If a function takes up to 20 ULONGs and returns ULONG: =item Same for a function which returns non-0 and sets system-error on error - call20_Dos( $msg, $pointer, $arg0, $arg1, ...); # die("$msg: $^E") if error + call20_Dos( $msg, $pointer, $arg0, $arg1, ...); # die("$msg: $^E") + if error [Good for C API - and rare C calls.] diff --git a/os2/OS2/OS2-REXX/REXX.pm b/os2/OS2/OS2-REXX/REXX.pm index ca9fee69ce..6d0ca4bc8e 100644 --- a/os2/OS2/OS2-REXX/REXX.pm +++ b/os2/OS2/OS2-REXX/REXX.pm @@ -11,7 +11,7 @@ require OS2::DLL; # Other items we are prepared to export if requested @EXPORT_OK = qw(drop register); -$VERSION = '1.04'; +$VERSION = '1.05'; # We cannot just put OS2::DLL in @ISA, since some scripts would use # function interface, not method interface... @@ -432,37 +432,38 @@ See C and the next section for examples. =head1 EXAMPLE - use OS2::REXX; + use OS2::REXX; - sub Ender::DESTROY { $vrexx->VExit; print "Exiting...\n" } + sub Ender::DESTROY { $vrexx->VExit; print "Exiting...\n" } - $vrexx = OS2::REXX->load('VREXX'); - REXX_call { # VOpenWindow takes a stem - local $SIG{TERM} = sub {die}; # enable Ender::DESTROY - local $SIG{INT} = sub {die}; # enable Ender::DESTROY + $vrexx = OS2::REXX->load('VREXX'); + REXX_call { # VOpenWindow takes a stem + local $SIG{TERM} = sub {die}; # enable Ender::DESTROY + local $SIG{INT} = sub {die}; # enable Ender::DESTROY - $code = $vrexx->VInit; - print "Init code = `$code'\n"; - die "error initializing VREXX" if $code eq 'ERROR'; + $code = $vrexx->VInit; + print "Init code = `$code'\n"; + die "error initializing VREXX" if $code eq 'ERROR'; - my $ender = bless [], 'Ender'; # Call Ender::DESTROY on exit + my $ender = bless [], 'Ender'; # Call Ender::DESTROY on exit - print "VREXX Version ", $vrexx->VGetVersion, "\n"; + print "VREXX Version ", $vrexx->VGetVersion, "\n"; - tie %pos, 'OS2::REXX', 'POS.' or die; - %pos = ( LEFT => 0, RIGHT => 7, TOP => 5, BOTTOM => 0 ); + tie %pos, 'OS2::REXX', 'POS.' or die; + %pos = ( LEFT => 0, RIGHT => 7, TOP => 5, BOTTOM => 0 ); - $id = $vrexx->VOpenWindow('To disconnect:', 'WHITE', 'POS'); - $vrexx->VForeColor($id, 'BLACK'); - $vrexx->VSetFont($id, 'TIME', '30'); - $tlim = time + 60; - while ( ($r = $tlim - time) >= 0 ) { - $vrexx->VClearWindow($id); - $vrexx->VSay($id, 100, 50, (sprintf "%02i:%02i", int($r/60), $r % 60)); - sleep 1; - } - print "Close code = `$res'\n" if $res = $vrexx->VCloseWindow($id); - }; + $id = $vrexx->VOpenWindow('To disconnect:', 'WHITE', 'POS'); + $vrexx->VForeColor($id, 'BLACK'); + $vrexx->VSetFont($id, 'TIME', '30'); + $tlim = time + 60; + while ( ($r = $tlim - time) >= 0 ) { + $vrexx->VClearWindow($id); + $vrexx->VSay($id, 100, 50, (sprintf "%02i:%02i", int($r/60), + $r % 60)); + sleep 1; + } + print "Close code = `$res'\n" if $res = $vrexx->VCloseWindow($id); + }; -- cgit v1.2.1