From b6d1426f94a845fb8fece8b6ad0b7d9f35f2d62e Mon Sep 17 00:00:00 2001 From: Zefram Date: Fri, 15 Jan 2010 17:13:17 +0100 Subject: [perl #62646] Maximum string length with substr (This is only a partial fix, since it doesn't handle lvalue substr) --- pp.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'pp.c') diff --git a/pp.c b/pp.c index c659b13a1f..4735c94cfb 100644 --- a/pp.c +++ b/pp.c @@ -3079,12 +3079,12 @@ PP(pp_substr) { dVAR; dSP; dTARGET; SV *sv; - I32 len = 0; + IV len = 0; STRLEN curlen; STRLEN utf8_curlen; - I32 pos; - I32 rem; - I32 fail; + IV pos; + IV rem; + IV fail; const I32 lvalue = PL_op->op_flags & OPf_MOD || LVRET; const char *tmps; const I32 arybase = CopARYBASE_get(PL_curcop); @@ -3147,7 +3147,7 @@ PP(pp_substr) rem = curlen; else if (len >= 0) { rem = pos+len; - if (rem > (I32)curlen) + if (rem > (IV)curlen) rem = curlen; } else { @@ -3167,8 +3167,8 @@ PP(pp_substr) RETPUSHUNDEF; } else { - const I32 upos = pos; - const I32 urem = rem; + const IV upos = pos; + const IV urem = rem; if (utf8_curlen) sv_pos_u2b(sv, &pos, &rem); tmps += pos; -- cgit v1.2.1