From 884fc2d39dfcec3db11eecde0cdd7c30846e153b Mon Sep 17 00:00:00 2001 From: Zefram Date: Thu, 18 Jan 2018 21:23:55 +0000 Subject: Revert "Revert "make PerlIO handle FD_CLOEXEC"" This reverts commit 523d71b314dc75bd212794cc8392eab8267ea744, reinstating commit 2cdf406af42834c46ef407517daab0734f7066fc. Reversion is not the way to address the porting problem that motivated that reversion. --- pp_sys.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'pp_sys.c') diff --git a/pp_sys.c b/pp_sys.c index 1556626484..5154b9baa8 100644 --- a/pp_sys.c +++ b/pp_sys.c @@ -692,8 +692,6 @@ PP(pp_pipe_op) if (PerlProc_pipe_cloexec(fd) < 0) goto badexit; - setfd_inhexec_for_sysfd(fd[0]); - setfd_inhexec_for_sysfd(fd[1]); IoIFP(rstio) = PerlIO_fdopen(fd[0], "r" PIPE_OPEN_MODE); IoOFP(wstio) = PerlIO_fdopen(fd[1], "w" PIPE_OPEN_MODE); @@ -2521,7 +2519,6 @@ PP(pp_socket) if (fd < 0) { RETPUSHUNDEF; } - setfd_inhexec_for_sysfd(fd); IoIFP(io) = PerlIO_fdopen(fd, "r" SOCKET_OPEN_MODE); /* stdio gets confused about sockets */ IoOFP(io) = PerlIO_fdopen(fd, "w" SOCKET_OPEN_MODE); IoTYPE(io) = IoTYPE_SOCKET; @@ -2558,8 +2555,6 @@ PP(pp_sockpair) TAINT_PROPER("socketpair"); if (PerlSock_socketpair_cloexec(domain, type, protocol, fd) < 0) RETPUSHUNDEF; - setfd_inhexec_for_sysfd(fd[0]); - setfd_inhexec_for_sysfd(fd[1]); IoIFP(io1) = PerlIO_fdopen(fd[0], "r" SOCKET_OPEN_MODE); IoOFP(io1) = PerlIO_fdopen(fd[0], "w" SOCKET_OPEN_MODE); IoTYPE(io1) = IoTYPE_SOCKET; @@ -2675,7 +2670,6 @@ PP(pp_accept) if (fd < 0) goto badexit; - setfd_inhexec_for_sysfd(fd); if (IoIFP(nstio)) do_close(ngv, FALSE); IoIFP(nstio) = PerlIO_fdopen(fd, "r" SOCKET_OPEN_MODE); -- cgit v1.2.1