From 3f6bd23a1b9204dda7aaaef6efe17dc87f50a675 Mon Sep 17 00:00:00 2001 From: David Mitchell Date: Mon, 15 Feb 2016 13:48:24 +0000 Subject: rename and function-ise dtrace macros This commit: 1. Renames the various dtrace probe macros into a consistent and self-documenting pattern, e.g. ENTRY_PROBE => PERL_DTRACE_PROBE_ENTRY RETURN_PROBE => PERL_DTRACE_PROBE_RETURN Since they're supposed to be defined only under PERL_CORE, this shouldn't break anything that's not being naughty. 2. Implement the main body of these macros using a real function. They were formerly defined along the lines of if (PERL_SUB_ENTRY_ENABLED()) PERL_SUB_ENTRY(...); The PERL_SUB_ENTRY() part is a macro generated by the dtrace system, which for example on linux expands to a large bunch of assembly directives. Replace the direct macro with a function wrapper, e.g. if (PERL_SUB_ENTRY_ENABLED()) Perl_dtrace_probe_call(aTHX_ cv, TRUE); This reduces to once the number of times the macro is expanded. The new functions also take simpler args and then process the values they need using intermediate temporary vars to avoid huge macro expansions. For example ENTRY_PROBE(CvNAMED(cv) ? HEK_KEY(CvNAME_HEK(cv)) : GvENAME(CvGV(cv)), CopFILE((const COP *)CvSTART(cv)), CopLINE((const COP *)CvSTART(cv)), CopSTASHPV((const COP *)CvSTART(cv))); is now PERL_DTRACE_PROBE_ENTRY(cv); This reduces the executable size by 1K on -O2 -Dusedtrace builds, and by 45K on -DDEBUGGING -Dusedtrace builds. --- run.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'run.c') diff --git a/run.c b/run.c index 1a62e9d66f..352bfbc18c 100644 --- a/run.c +++ b/run.c @@ -37,9 +37,9 @@ int Perl_runops_standard(pTHX) { OP *op = PL_op; - OP_ENTRY_PROBE(OP_NAME(op)); + PERL_DTRACE_PROBE_OP(op); while ((PL_op = op = op->op_ppaddr(aTHX))) { - OP_ENTRY_PROBE(OP_NAME(op)); + PERL_DTRACE_PROBE_OP(op); } PERL_ASYNC_CHECK(); -- cgit v1.2.1