From 861a58daef615e7ade791b887911ef3caba8c539 Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sun, 7 Oct 2012 11:10:16 -0600
Subject: t/TEST: $failure doesnt need to use defined

$failure handling in <$results> processing loop does not need extra
subtlety of defined-ness checks - just give it an initial (false)
value, and check for truth.
---
 t/TEST | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

(limited to 't/TEST')

diff --git a/t/TEST b/t/TEST
index 8026c535db..9ad23a9b5e 100755
--- a/t/TEST
+++ b/t/TEST
@@ -531,7 +531,7 @@ EOT
     my $grind_ct = 0;		# count of non-empty valgrind reports
     my $total_files = @tests;
     my $good_files = 0;
-    my $tested_files  = 0;
+    my $tested_files = 0;
     my $totmax = 0;
     my %failed_tests;
     my $toolnm;		# valgrind, cachegrind, perf
@@ -567,7 +567,7 @@ EOT
 
 	my $results = _run_test($test, $type);
 
-	my $failure;
+	my $failure = "";
 	my $next = 0;
 	my $seen_leader = 0;
 	my $seen_ok = 0;
@@ -660,7 +660,7 @@ EOT
 	}
 	close $results;
 
-	if (not defined $failure) {
+	if (not $failure) {
 	    $failure = 'FAILED--no leader found' unless $seen_leader;
 	}
 
@@ -669,13 +669,11 @@ EOT
 	if ($type eq 'deparse' && !$ENV{KEEP_DEPARSE_FILES}) {
 	    unlink "./$test.dp";
 	}
-	if (not defined $failure and $next != $max) {
+	if (not $failure and $next != $max) {
 	    $failure="FAILED--expected $max tests, saw $next";
 	}
 
-	if( !defined $failure  # don't mask a test failure
-	    and $? )
-	{
+	if (not $failure and $? ) {	# don't mask a test failure
 	    $failure = "FAILED--non-zero wait status: $?";
 	}
 
@@ -692,7 +690,7 @@ EOT
 	    }
 	}
 
-	if (defined $failure) {
+	if ($failure) {
 	    print "${te}$failure\n";
 	    $::bad_files = $::bad_files + 1;
 	    if ($test =~ /^base/ && ! defined &DynaLoader::boot_DynaLoader) {
-- 
cgit v1.2.1